You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/04/04 19:06:47 UTC

[GitHub] [arrow] felipecrv opened a new issue, #34893: [C++] Add operator--() to RunEndEncodedArraySpan::Iterator and make it stop violating loop invariants

felipecrv opened a new issue, #34893:
URL: https://github.com/apache/arrow/issues/34893

   ### Describe the enhancement requested
   
   The value of `RunEndEncodedArraySpan::Iterator::physical_pos_` from the instance returned by `RunEndEncodedArraySpan::end()` is smaller (by 1) than the results of successive applications of `operator++` until `logical_pos_` reaches the logical length of the run-end encoded array.
   
   *Why this is important?*
   
   To support backwards iteration, the `Iterator` returned by `RunEndEncodedArraySpan::end()` should be well-formed.
   
   *Why this is not a bug?*
   
   There is no `operator--()` in `RunEndEncodedArraySpan::Iterator` yet, so you can't go backwards from `end()`. A fix for this issue adds that operator and uses it in tests that guarantee iterators are always valid and don't assume iteration only happens in one direction.
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] felipecrv commented on issue #34893: [C++] Add operator--() to RunEndEncodedArraySpan::Iterator and make it stop violating loop invariants

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.

felipecrv commented on issue #34893:
URL: https://github.com/apache/arrow/issues/34893#issuecomment-1496463420

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade closed issue #34893: [C++] Add operator--() to RunEndEncodedArraySpan::Iterator and make it stop violating loop invariants

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.

zeroshade closed issue #34893: [C++] Add operator--() to RunEndEncodedArraySpan::Iterator and make it stop violating loop invariants
URL: https://github.com/apache/arrow/issues/34893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org