You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anupama Gupta (Code Review)" <ge...@cloudera.org> on 2018/08/17 00:07:17 UTC
[kudu-CR] Efficiently support predicates on non-prefix key components
Anupama Gupta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11252
Change subject: Efficiently support predicates on non-prefix key components
......................................................................
Efficiently support predicates on non-prefix key components
This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.
This feature uses the following approach:
1. Seek at the first unique prefix key in the ad-hoc index tree.
2. Seek to the relevant entry corresponding to the unique prefix key
found in 1. and the predicate value on the suffix key column.
3. To handle the case where multiple entries exist with respect to
a unique prefix key, store the upper bound index of these entries.
4. Repeat steps 1-3, till all the unique prefix keys are scanned.
Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
10 files changed, 1,248 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/11252/1
--
To view, visit http://gerrit.cloudera.org:8080/11252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
Gerrit-Change-Number: 11252
Gerrit-PatchSet: 1
Gerrit-Owner: Anupama Gupta <an...@cloudera.com>
[kudu-CR] Efficiently support predicates on non-prefix key components
Posted by "Anupama Gupta (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11252
to look at the new patch set (#5).
Change subject: Efficiently support predicates on non-prefix key components
......................................................................
Efficiently support predicates on non-prefix key components
This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.
This feature uses the following approach:
1. Seek at the first unique prefix key in the ad-hoc index tree.
2. Seek to the relevant entry corresponding to the unique prefix key
found in 1. and the predicate value on the suffix key column.
3. To handle the case where multiple entries exist with respect to
a unique prefix key, store the upper bound index of these entries.
4. Repeat steps 1-3, till all the unique prefix keys are scanned.
Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
10 files changed, 1,261 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/11252/5
--
To view, visit http://gerrit.cloudera.org:8080/11252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
Gerrit-Change-Number: 11252
Gerrit-PatchSet: 5
Gerrit-Owner: Anupama Gupta <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Efficiently support predicates on non-prefix key components
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11252 )
Change subject: Efficiently support predicates on non-prefix key components
......................................................................
Patch Set 5:
Did you mean to create a new CR? I'll continue reviewing on the other one since that's where all the other review comments are.
--
To view, visit http://gerrit.cloudera.org:8080/11252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
Gerrit-Change-Number: 11252
Gerrit-PatchSet: 5
Gerrit-Owner: Anupama Gupta <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Aug 2018 20:52:49 +0000
Gerrit-HasComments: No
[kudu-CR] Efficiently support predicates on non-prefix key components
Posted by "Anupama Gupta (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11252
to look at the new patch set (#2).
Change subject: Efficiently support predicates on non-prefix key components
......................................................................
Efficiently support predicates on non-prefix key components
This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.
This feature uses the following approach:
1. Seek at the first unique prefix key in the ad-hoc index tree.
2. Seek to the relevant entry corresponding to the unique prefix key
found in 1. and the predicate value on the suffix key column.
3. To handle the case where multiple entries exist with respect to
a unique prefix key, store the upper bound index of these entries.
4. Repeat steps 1-3, till all the unique prefix keys are scanned.
Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
10 files changed, 1,256 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/11252/2
--
To view, visit http://gerrit.cloudera.org:8080/11252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
Gerrit-Change-Number: 11252
Gerrit-PatchSet: 2
Gerrit-Owner: Anupama Gupta <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Efficiently support predicates on non-prefix key components
Posted by "Anupama Gupta (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11252
to look at the new patch set (#4).
Change subject: Efficiently support predicates on non-prefix key components
......................................................................
Efficiently support predicates on non-prefix key components
This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.
This feature uses the following approach:
1. Seek at the first unique prefix key in the ad-hoc index tree.
2. Seek to the relevant entry corresponding to the unique prefix key
found in 1. and the predicate value on the suffix key column.
3. To handle the case where multiple entries exist with respect to
a unique prefix key, store the upper bound index of these entries.
4. Repeat steps 1-3, till all the unique prefix keys are scanned.
Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
10 files changed, 1,261 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/11252/4
--
To view, visit http://gerrit.cloudera.org:8080/11252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
Gerrit-Change-Number: 11252
Gerrit-PatchSet: 4
Gerrit-Owner: Anupama Gupta <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Efficiently support predicates on non-prefix key components
Posted by "Anupama Gupta (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11252
to look at the new patch set (#3).
Change subject: Efficiently support predicates on non-prefix key components
......................................................................
Efficiently support predicates on non-prefix key components
This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.
This feature uses the following approach:
1. Seek at the first unique prefix key in the ad-hoc index tree.
2. Seek to the relevant entry corresponding to the unique prefix key
found in 1. and the predicate value on the suffix key column.
3. To handle the case where multiple entries exist with respect to
a unique prefix key, store the upper bound index of these entries.
4. Repeat steps 1-3, till all the unique prefix keys are scanned.
Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
10 files changed, 1,256 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/11252/3
--
To view, visit http://gerrit.cloudera.org:8080/11252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9f5a4f2e9da39211d645b4d6d163ecdf919e5d2
Gerrit-Change-Number: 11252
Gerrit-PatchSet: 3
Gerrit-Owner: Anupama Gupta <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins