You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Lisheng Sun (Jira)" <ji...@apache.org> on 2020/05/05 07:36:00 UTC

[jira] [Comment Edited] (HDFS-15255) Consider StorageType when DatanodeManager#sortLocatedBlock()

    [ https://issues.apache.org/jira/browse/HDFS-15255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099607#comment-17099607 ] 

Lisheng Sun edited comment on HDFS-15255 at 5/5/20, 7:35 AM:
-------------------------------------------------------------

the v007 patch removes equals and hashCode from DatanodeInfoWithStorage.

it reports find-bugs warnging as follow:

org.apache.hadoop.hdfs.protocol.DatanodeInfoWithStorage doesn't override DatanodeInfo.equals(Object) At DatanodeInfoWithStorage.java:At DatanodeInfoWithStorage.java:[line 1]

the v008 adds back equals and hashCode to DatanodeInfoWithStorage.


was (Author: leosun08):
the v007 patch removes equals and hashCode from DatanodeInfoWithStorage.

it report find-bugs warnging as follow:

org.apache.hadoop.hdfs.protocol.DatanodeInfoWithStorage doesn't override DatanodeInfo.equals(Object) At DatanodeInfoWithStorage.java:At DatanodeInfoWithStorage.java:[line 1]

the v008 add back equals and hashCode from DatanodeInfoWithStorage.

> Consider StorageType when DatanodeManager#sortLocatedBlock()
> ------------------------------------------------------------
>
>                 Key: HDFS-15255
>                 URL: https://issues.apache.org/jira/browse/HDFS-15255
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Lisheng Sun
>            Assignee: Lisheng Sun
>            Priority: Major
>             Fix For: 3.4.0
>
>         Attachments: HDFS-15255-findbugs-test.001.patch, HDFS-15255.001.patch, HDFS-15255.002.patch, HDFS-15255.003.patch, HDFS-15255.004.patch, HDFS-15255.005.patch, HDFS-15255.006.patch, HDFS-15255.007.patch, HDFS-15255.008.patch, experiment-find-bugs.001.patch
>
>
> When only one replica of a block is SDD, the others are HDD. 
> When the client reads the data, the current logic is that it considers the distance between the client and the dn. I think it should also consider the StorageType of the replica. Priority to return fast StorageType node when the distance is same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org