You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/07/30 11:27:59 UTC
[GitHub] yanghua commented on a change in pull request #6451: [FLINK-9936]
Resource manager connect to mesos after leadership granted. .
yanghua commented on a change in pull request #6451: [FLINK-9936] Resource manager connect to mesos after leadership granted. .
URL: https://github.com/apache/flink/pull/6451#discussion_r206097341
##########
File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
##########
@@ -221,10 +221,14 @@ protected ActorRef createReconciliationCoordinator(SchedulerDriver schedulerDriv
// ------------------------------------------------------------------------
/**
- * Starts the Mesos-specifics.
+ * Do nothing and all work has been moved to on leadership granted callback.
Review comment:
replace "on leadership granted" to "onLeaderShipGranted" looks better to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services