[GitHub] [orc] dongjoon-hyun commented on a change in pull request #582: ORC-697: Improve scan tool to report the location of corruption.

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #582:
URL: https://github.com/apache/orc/pull/582#discussion_r542924664



##########
File path: java/tools/src/java/org/apache/orc/tools/ScanData.java
##########
@@ -40,41 +40,168 @@
 
   static CommandLine parseCommandLine(String[] args) throws ParseException {
     Options options = new Options()
-        .addOption("help", "h", false, "Provide help");
-    return new GnuParser().parse(options, args);
+        .addOption("s", "schema", false, "Print schema")
+        .addOption("h", "help", false, "Provide help");
+    return new DefaultParser().parse(options, args);

Review comment:
       Oh, are we moving from `GnuParser` to `DefaultParser`? I'm just wondering because we have some more `GnuParser` code on the `master` branch.
   ```
   $ git grep DefaultParser | wc -l
         12
   $ git grep GnuParser | wc -l
         10
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org