You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/10/16 17:27:55 UTC

[GitHub] [couchdb] nickva commented on a diff in pull request #4210: Make test prometheus port explicit

nickva commented on code in PR #4210:
URL: https://github.com/apache/couchdb/pull/4210#discussion_r996470012


##########
src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl:
##########
@@ -81,6 +81,7 @@ setup_prometheus(WithAdditionalPort) ->
         WithAdditionalPort,
         Persist
     ),
+    ok = config:set("prometheus", "port", ?PROM_PORT),

Review Comment:
   Should we set `Persist=false`? Or we specifically want to set it and keep at in the config file across restarts here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org