You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/09/13 16:35:47 UTC

[GitHub] [daffodil-vscode] arosien commented on a diff in pull request #253: Daffodil vscode tdml

arosien commented on code in PR #253:
URL: https://github.com/apache/daffodil-vscode/pull/253#discussion_r969854108


##########
.vscode/launch.json:
##########
@@ -48,6 +48,15 @@
 			],
 			"internalConsoleOptions": "openOnSessionStart",
 			"preLaunchTask": "npm: compile"
+		},
+		{
+			"type": "scala",
+			"request": "launch",
+			"name": "DAPodil",

Review Comment:
   Suggestion: let's rename the launch entry here to be something like "Daffodil DAP Server" to be a clear description of what it does. The name of the mainClass shouldn't matter too much.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org