You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/08/25 00:55:55 UTC

[GitHub] [incubator-kvrocks] ShooterIT commented on pull request #791: Use PutVarInt instead of PutFixed while encoding stream entry value

ShooterIT commented on PR #791:
URL: https://github.com/apache/incubator-kvrocks/pull/791#issuecomment-1226649866

   > Is it too late to introduce such a change?
   
   I don't think it is late, since now it is only on `unstable` branch which we may make changes on it.
   
   one problem we need to concern is about open source license about these codes copied from leveldb/rocksdb.
   should we put its license header. And is `xxFixed32` copied from leveldb/rocksdb, should we describe this? @git-hulk 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org