You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2016/06/24 19:51:31 UTC
[Impala-CR](cdh5-trunk) IMPALA-2890: Add support for ALTER for Kudu tables
Bikramjeet Vig has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3485
Change subject: IMPALA-2890: Add support for ALTER for Kudu tables
......................................................................
IMPALA-2890: Add support for ALTER for Kudu tables
Currently we only support altering table name and table properties.
Also, altering table name only changed it inside impala
but the name remained same in Kudu.
This patch adds support for using ALTER command to change table name
both inside impala and kudu, drop column and add nullable columns.
Support for adding non-nullable columns has not been added since
we do not support specifying default column value in the column spec.
Support for renaming columns for kudu tables has not been added since
we do not support this functionality at all.
TESTING:
Test files AnalyzeDDLTest.java and kudu_alter.test have been
modified to include tests for checking these functionalities
Change-Id: I547623c090b4ffbe86e024a128576e7236d1ab41
---
M fe/src/main/java/com/cloudera/impala/analysis/AlterTableAddReplaceColsStmt.java
M fe/src/main/java/com/cloudera/impala/analysis/AlterTableStmt.java
M fe/src/main/java/com/cloudera/impala/catalog/delegates/KuduDdlDelegate.java
M fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
6 files changed, 150 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/85/3485/1
--
To view, visit http://gerrit.cloudera.org:8080/3485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I547623c090b4ffbe86e024a128576e7236d1ab41
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-2890: Add support for ALTER for Kudu tables
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has abandoned this change.
Change subject: IMPALA-2890: Add support for ALTER for Kudu tables
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/3485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I547623c090b4ffbe86e024a128576e7236d1ab41
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-2890: Add support for ALTER for Kudu tables
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has uploaded a new patch set (#2).
Change subject: IMPALA-2890: Add support for ALTER for Kudu tables
......................................................................
IMPALA-2890: Add support for ALTER for Kudu tables
Currently we only support altering table name and table properties.
Also, altering table name only changed it inside impala
but the name remained same in Kudu.
This patch adds support for using ALTER command to change table name
both inside impala and kudu, drop column and add nullable columns.
Support for adding non-nullable columns has not been added since
we do not support specifying default column value in the column spec.
Support for renaming columns for kudu tables has not been added since
we do not support this functionality at all.
TESTING:
Test files AnalyzeDDLTest.java and kudu_alter.test have been
modified to include tests for checking these functionalities
Change-Id: I547623c090b4ffbe86e024a128576e7236d1ab41
---
M fe/src/main/java/com/cloudera/impala/analysis/AlterTableAddReplaceColsStmt.java
M fe/src/main/java/com/cloudera/impala/analysis/AlterTableStmt.java
M fe/src/main/java/com/cloudera/impala/catalog/delegates/KuduDdlDelegate.java
M fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
6 files changed, 161 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/85/3485/2
--
To view, visit http://gerrit.cloudera.org:8080/3485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I547623c090b4ffbe86e024a128576e7236d1ab41
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-2890: Add support for ALTER for Kudu tables
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-2890: Add support for ALTER for Kudu tables
......................................................................
Patch Set 2:
Please update to using the new gerrit project, "Impala-ASF".
Instructions are here:
https://cwiki.apache.org/confluence/display/IMPALA/How+to+switch+to+Apache-hosted+git
Pushes to this project will be disabled on October 1.
--
To view, visit http://gerrit.cloudera.org:8080/3485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I547623c090b4ffbe86e024a128576e7236d1ab41
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No