[GitHub] [cloudstack] rhtyd commented on a change in pull request #3857: vr: add missing rule for port forwarding rule in vpc

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#discussion_r375651344
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/configure.py
 ##########
 @@ -930,8 +936,20 @@ def forward_vpc(self, rule):
         if not rule["internal_ports"] == "any":
             fw_output_rule += ":" + self.portsToString(rule["internal_ports"], "-")
 
+        fw_postrout_rule2 = "-j SNAT --to-source %s -A POSTROUTING -s %s -d %s/32 -o %s -p %s -m %s --dport %s" % \
+              (
 
 Review comment:
   @ustcweizhou can you fix the indent issue here, run `pycodestyle --max-line-length=179` on this file to confirm. See Travis' 1st job failure for hints: `../debian/opt/cloud/bin/configure.py:940:15: E127 continuation line over-indented for visual indent`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services