[GitHub] wes3 commented on issue #711: Initial ARCv2 port of mynewt

[GitBox <gi...@apache.org>]

wes3 commented on issue #711: Initial ARCv2 port of mynewt
URL: https://github.com/apache/mynewt-core/pull/711#issuecomment-355671103
 
 
   Thanks for the review Marko. Here are my comments.
   
   I fixed the last two of your comments as they were simple. However, I am not sure what to do about the rest:
   
   1) I am happy to remove any files that should be removed from the SDK. The ones you pointed out I can easily remove but not sure which others should be on the removal list. I am not even sure I would be able to recognize all the files which should be removed :-)
   
   2) I really know nothing about licensing. The files without licenses come from their SDK and have been adapted for mynewt. What should I do here? Add the apache license to them only? Add the synopsys license? Add both?
   
   3) The Synopsys license appears to be a standard 3-clause BSD license. I can add a section for Synopsys in the top-level license file easily enough for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services