You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/06/16 10:39:16 UTC
[PR] Add license header check to CI [datafusion-sqlparser-rs]
alamb opened a new pull request, #1888:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1888
I [hit a small snag creating a 0.57.0 release ](https://github.com/apache/datafusion-sqlparser-rs/issues/1837#issuecomment-2976015123) due to a file not having the required apache license header.
I made another PR to add the headers
- https://github.com/apache/datafusion-sqlparser-rs/pull/1887
This PR adds a CI check to ensure newly added files have the header too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add license header check to CI [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #1888:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add license header check to CI [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1888:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1888#issuecomment-2980583065
Finally got a clean run: https://github.com/apache/datafusion-sqlparser-rs/actions/runs/15709899490/job/44264929194?pr=1888
😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add license header check to CI [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1888:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1888#issuecomment-2976045858
The new CI test fails with the same message I got when creating the release candidate, as expected (I expect it to fail until https://github.com/apache/datafusion-sqlparser-rs/pull/1887 is merged)
https://github.com/apache/datafusion-sqlparser-rs/actions/runs/15678566227/job/44164458033?pr=1888
```
Run ./dev/release/run-rat.sh .
NOT APPROVED: rat.txt (./rat.txt): false
NOT APPROVED: src/display_utils.rs (./src/display_utils.rs): false
NOT APPROVED: tests/pretty_print.rs (./tests/pretty_print.rs): false
3 unapproved licences. Check rat report: rat.txt
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org