[jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start

["Jonathan Hsieh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526023#comment-13526023 ] 

Jonathan Hsieh commented on HBASE-7294:
---------------------------------------

I think we should not allow snapshots if the proper cleaner is not installed, and I think the rs and hm startup code should also check to see if there are .snapshots present and abort startup if the proper cleaner is not installed with a log message saying that this must be done.

We *do not* want to even allow an admin accidentally change something that could result in data loss.
                
> Check for snapshot file cleaners on start
> -----------------------------------------
>
>                 Key: HBASE-7294
>                 URL: https://issues.apache.org/jira/browse/HBASE-7294
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, master, regionserver, snapshots, Zookeeper
>    Affects Versions: hbase-6055
>            Reporter: Jesse Yates
>             Fix For: hbase-6055, 0.96.0
>
>
> From Matteo Bertozzi:
> {quote}
> currently the snapshot cleaner is not in hbase-default.xml
> and there's no warning/exception on snapshot/restore operation, if not enabled.
> even if we add the cleaner to the hbase-default.xml how do we ensure that the user doesn't remove it?
> Do we want to hardcode the cleaner at master startup?
> Do we want to add a check in snapshot/restore that throws an exception if the cleaner is not enabled?
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira