[GitHub] [iceberg] lirui-apache commented on a diff in pull request #6175: Hive: Add UGI to the key in CachedClientPool

[GitBox <gi...@apache.org>]

lirui-apache commented on code in PR #6175:
URL: https://github.com/apache/iceberg/pull/6175#discussion_r1022669799


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/CachedClientPool.java:
##########
@@ -87,4 +91,23 @@ public <R> R run(Action<R, IMetaStoreClient, TException> action, boolean retry)
       throws TException, InterruptedException {
     return clientPool().run(action, retry);
   }
+
+  @VisibleForTesting
+  @Value.Immutable
+  abstract static class Key {

Review Comment:
   Yeah, our use case here only needs the UGI, we can extend the cache key to take more values as needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org