You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/08 11:24:13 UTC
[GitHub] [spark] pan3793 opened a new pull request, #38981: [SPARK-41376][CORE][3.3] Correct the Netty preferDirectBufs check logic on executor start
pan3793 opened a new pull request, #38981:
URL: https://github.com/apache/spark/pull/38981
### What changes were proposed in this pull request?
Backport #38901 to branch-3.3.
Fix the condition for judging Netty prefer direct memory on executor start, the logic should match `org.apache.spark.network.client.TransportClientFactory`.
### Why are the changes needed?
The check logical was added in SPARK-27991, the original intention is to avoid potential Netty OOM issue when Netty uses direct memory to consume shuffle data, but the condition is not sufficient, this PR updates the logic to match `org.apache.spark.network.client.TransportClientFactory`
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #38981: [SPARK-41376][CORE][3.3] Correct the Netty preferDirectBufs check logic on executor start
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #38981: [SPARK-41376][CORE][3.3] Correct the Netty preferDirectBufs check logic on executor start
URL: https://github.com/apache/spark/pull/38981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38981: [SPARK-41376][CORE][3.3] Correct the Netty preferDirectBufs check logic on executor start
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38981:
URL: https://github.com/apache/spark/pull/38981#issuecomment-1343173853
Merged to branch-3.3. Thank you, @pan3793 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org