[GitHub] [superset] michael-s-molina edited a comment on pull request #13037: feat: add autocopy functionality to CopyToClipboard (#10328)

[GitBox <gi...@apache.org>]

michael-s-molina edited a comment on pull request #13037:
URL: https://github.com/apache/superset/pull/13037#issuecomment-776957184


   > @michael-s-molina Thanks for the quick simulation!
   > 
   > I think this works for the dashboard page. For the Explore page though, looking at this more, I'm now no so sure about replacing the icon as it's not very clear what does a copy icon mean. Most first-time users would probably associate it with copying the data, the query, or the chart metadata, not a short-url.
   > 
   > Here's another proposal: wow about we keep the popover but make it open on hover and remove the animation?
   
   @ktmud I totally agree about the copy icon but I really like the idea to remove the popover and make this action more straightforward. Can't we just use the Fontawesome link icon? It's already being used in other copy buttons like this one:
   
   <img width="121" alt="Screen Shot 2021-02-10 at 4 01 52 PM" src="https://user-images.githubusercontent.com/70410625/107558340-6a365700-6bb9-11eb-909a-7f8a8cce1735.png">
   
   I think the user will quickly assimilate, and also we have the tooltip to help. It would look like this:
   
   <img width="280" alt="Screen Shot 2021-02-10 at 4 24 17 PM" src="https://user-images.githubusercontent.com/70410625/107560708-766fe380-6bbc-11eb-9afe-a0c670c4caf2.png">
   
   or
   
   <img width="257" alt="Screen Shot 2021-02-10 at 4 21 57 PM" src="https://user-images.githubusercontent.com/70410625/107560496-314bb180-6bbc-11eb-896d-1a3e95e3868c.png">
   
   What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org