You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2026/09/25 17:08:07 UTC
[PR] Remove vestigial @SuppressWarnings("deprecation") from handleReplicationFactor [solr]
epugh opened a new pull request, #4945:
URL: https://github.com/apache/solr/pull/4945
## Summary
- `DistributedZkUpdateProcessor.handleReplicationFactor()` carries a `@SuppressWarnings("deprecation")` that no longer guards anything.
- It was added in SOLR-12955 (2019) alongside a reference to the deprecated `UpdateRequest.MIN_REPFACT` (`min_rf`) response field, kept only for rolling-upgrade compatibility with pre-7.x clients.
- SOLR-14034 (#2152) removed that `min_rf` handling in 2021 but left the annotation behind.
- Verified with `-Xlint:deprecation` (with the suppression removed) that the method produces zero deprecation warnings today, so the annotation is dead weight.
## Test plan
- [x] `./gradlew :solr:core:compileJava` with `-Xlint:deprecation` enabled confirms no warning is emitted for this method (or file) without the suppression.
- [x] `./gradlew :solr:core:test --tests "org.apache.solr.cloud.ReplicationFactorTest"` passes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01EtAaTxk6uj5HARVtKqEF32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Remove vestigial @SuppressWarnings("deprecation") from handleReplicationFactor [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #4945:
URL: https://github.com/apache/solr/pull/4945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org