You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/31 22:43:30 UTC

Review Request 63455: Fixed Protobuf header dependency.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63455/
-----------------------------------------------------------

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
-------

While the header files were being created correctly, the explicit
dependency in the `CUSTOM_COMMAND` did not exist. Though we depended on
`${H}`, the variable was empty as we forgot to set it.


Diffs
-----

  src/cmake/MesosProtobuf.cmake 533455e3b650dfb9e2b8c73e83c60ecc99613985 


Diff: https://reviews.apache.org/r/63455/diff/1/


Testing
-------

Re-ran CMake and inspected output files. The explicit dependency on this header now exists.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 63455: Fixed Protobuf header dependency.

Posted by Benjamin Bannier <bb...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63455/#review189765
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On Oct. 31, 2017, 11:43 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63455/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2017, 11:43 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While the header files were being created correctly, the explicit
> dependency in the `CUSTOM_COMMAND` did not exist. Though we depended on
> `${H}`, the variable was empty as we forgot to set it.
> 
> 
> Diffs
> -----
> 
>   src/cmake/MesosProtobuf.cmake 533455e3b650dfb9e2b8c73e83c60ecc99613985 
> 
> 
> Diff: https://reviews.apache.org/r/63455/diff/1/
> 
> 
> Testing
> -------
> 
> Re-ran CMake and inspected output files. The explicit dependency on this header now exists.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>