You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jd...@apache.org on 2008/06/01 10:35:53 UTC
svn commit: r662172 -
/geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/application/DefaultVariables.java
Author: jdillon
Date: Sun Jun 1 01:35:52 2008
New Revision: 662172
URL: http://svn.apache.org/viewvc?rev=662172&view=rev
Log:
Comment
Modified:
geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/application/DefaultVariables.java
Modified: geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/application/DefaultVariables.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/application/DefaultVariables.java?rev=662172&r1=662171&r2=662172&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/application/DefaultVariables.java (original)
+++ geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/application/DefaultVariables.java Sun Jun 1 01:35:52 2008
@@ -195,6 +195,10 @@
return parent;
}
+ //
+ // FIXME: Move to some other class...
+ //
+
public static boolean isIdentifier(final String name) {
if (name == null || name.length() == 0) {
return false;
@@ -207,7 +211,6 @@
}
/*
-
FIXME: This fails for stuff like 'gshell.prompt' which we should allow
Eventually need to get this fixed, for now just skip part checking