You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/10 02:46:17 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26824: [SPARK-30197][PYSPARK] Add minimum `requirements.txt` file to `python` directory

dongjoon-hyun commented on a change in pull request #26824: [SPARK-30197][PYSPARK] Add minimum `requirements.txt` file to `python` directory
URL: https://github.com/apache/spark/pull/26824#discussion_r355820626
 
 

 ##########
 File path: python/requirements.txt
 ##########
 @@ -0,0 +1,4 @@
+numpy==1.16.4
+scipy==1.2.2
 
 Review comment:
   According to the UT, something doesn't work without these. 
   The file itself is just a conventional file for `pip`. Users can setup easily with `pip install -r python/requirements.txt`.
   
   If we use `==`, all mismatched versions (both lower and higher) will be removed and reinstalled with the exact versions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org