[jira] [Commented] (COUCHDB-2666) Regression: inproper local database name escape on /_replicate

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966538#comment-14966538 ] 

ASF GitHub Bot commented on COUCHDB-2666:
-----------------------------------------

GitHub user kxepal opened a pull request:

    https://github.com/apache/couchdb-chttpd/pull/84

    Escape database name on POST /_replicate

    COUCHDB-2666
    
    Reintroduce https://github.com/apache/couchdb-chttpd/pull/35 changes since issue was not fixed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kxepal/couchdb-chttpd 2666-replicate-db-escape

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-chttpd/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
    
----
commit bf604a5ea092d3b90ba4fed8483c000d68d0130f
Author: Alexander Shorin <kx...@apache.org>
Date:   2015-10-20T18:04:31Z

    Use real chttpd port for URI construct
    
    Those port that we get from config works fine until we start to ask
    for a random port.

commit 976b09a8b44a2bcc082450a48962f95ebd6c0b0d
Author: Alexander Shorin <kx...@apache.org>
Date:   2015-10-20T18:13:39Z

    Escape database name on POST /_replicate
    
    COUCHDB-2666

----


> Regression: inproper local database name escape on /_replicate
> --------------------------------------------------------------
>
>                 Key: COUCHDB-2666
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2666
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: HTTP Interface, Replication
>            Reporter: Alexander Shorin
>            Assignee: ILYA
>            Priority: Blocker
>              Labels: regression
>             Fix For: 2.0.0
>
>
> {code}
> $ curl -XPUT http://localhost:15984/foo%2fbar
> {"ok":true}
> $ curl -XPOST http://localhost:15984/_replicate -d '{"source": "foo/bar", "target": "baz", "create_target": true}' -H "Content-Type: application/json"
> {"error":"db_not_found","reason":"could not open http://127.0.0.1:15984/foo/bar/"}
> {code}
> Meanwhile in 1.6.1:
> {code}
> $ curl -XPUT http://localhost:5984/foo%2fbar
> {"ok":true}
> $ curl -XPOST http://localhost:5984/_replicate -d '{"source": "foo/bar", "target": "baz", "create_target": true}' -H "Content-Type: application/json"
> {"ok":true,"no_changes":true}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)