You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2012/11/05 17:10:23 UTC

[Bug 54101] New: Socket backend support for mod_proxy

https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

          Priority: P2
            Bug ID: 54101
          Assignee: bugs@httpd.apache.org
           Summary: Socket backend support for mod_proxy
          Severity: enhancement
    Classification: Unclassified
                OS: Linux
          Reporter: framelio@gmail.com
          Hardware: All
            Status: NEW
           Version: 2.4.3
         Component: mod_proxy
           Product: Apache httpd-2

Created attachment 29549
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29549&action=edit
Patch for socket support on mod_proxy

Currently mod_proxy and mod_proxy_fcgi doesn't support for a UNIX socket
backend.

Speaking about FCGI protocol and PHP, generally many PHP-FPM server
configurations are using a socket backend instead of the standard TCP
connection.

NGINXx supports it and the mod_fastcgi too with the config:
FastCgiExternalServer /cgi-bin/php-path -socket /path/to/socket/php-fpm.sock

A proposed patch and solution can be found here:
http://www.gossamer-threads.com/lists/apache/dev/416627

The example config format proposed is the following:

ProxyPass fcgi://socket=%2ftmp%2fphp-fpm.sock/local/htdocs/ 

I tested the patch on the version 2.4.3 and it works, even if the patch file
should be slightly adapted to the latest changed in the Apache HTTPD code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Marcel <m....@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.hofer117@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #3 from DH <dh...@plusline.de> ---
+1 for stable implementation in the next http 2.4.x releases

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #19 from Yann Ylavic <yl...@gmail.com> ---
Created attachment 31232
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31232&action=edit
Patch for 2.4.x (or 2.4.7)

This patch is the same as http://people.apache.org/~jim/patches/uds-2.4.patch
(modulo CHANGES/manual/ap_mmn.h) working with current 2.4.x (and 2.4.7).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #20 from Vedran Rodic <vr...@gmail.com> ---
It seems that this patch has landed  in 2.4.8/2.4.9.

But I'm not sure how to use it with ProxyPassMatch

I've tried the example above (fcgi://socket=%2ftmp%2fphp-fpm.sock/local/htdocs/
) but that didn't work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #21 from Francesco <fr...@gmail.com> ---
I did a test and the correct syntax for ProxyPassMatch is

ProxyPassMatch ^/(.*\.php(/.*)?)$
unix:/path/to/socket.sock|fcgi://localhost/path/to/docroot/

The host localhost doesn't really matter, you can put whatever.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #7 from ubunciak <ub...@gmail.com> ---
+1 for stable implementation, waiting for this so long. It's critical to use
with php-fpm

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #11 from Chris Pitchford <ap...@intrepid.cx> ---
I second this, 64 bytes is not sufficiently long. It is prohibitively short
when, for example, using Amazon AWS long hostnames for back end systems

Have I missed a reason why it needs to be so short? According to wikipedia (and
I fully appreciate this is very unprofessional to quote WP)

http://en.wikipedia.org/wiki/Hostname

Each label must be between 1 and 63 characters long,[2] and the entire hostname
(including the delimiting dots) has a maximum of 255 characters

Can we assume that the backend can be FQDN not just a single host? 255
characters would seem a minimum for a FQDN. 64 is only sufficient for a single
hostname.


(In reply to ryotakatsuki from comment #9)
> I see the patch already included in trunk but the part in which the 
> PROXY_WORKER_MAX_HOSTNAME_SIZE and PROXY_WORKER_MAX_NAME_SIZE were increased
> is not there (I realized that after get a "ProxyPass worker name
> (fcgi://uds=%2fsome%2fsocket.sock/tmp/somedirectory too long)"). Was that
> dropped intentionally?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

RoyBellingan <ad...@seisho.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |admin@seisho.us

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #8 from phpfpm1@gmail.com ---
Please check https://issues.apache.org/bugzilla/show_bug.cgi?id=54616#c7. It is
related to this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Eric Covener <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #23 from Eric Covener <co...@gmail.com> ---
in 2.4.7

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

erik@erikwebb.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |erik@erikwebb.net

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #15 from me@nileshgr.com ---
Damn, guess I need to use mod FastCGI till the next major version release. 
Thankfully someone was kind enough to release a 2.4 compatible version
https://github.com/ByteInternet/libapache-mod-fastcgi

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #24 from RoyBellingan <ad...@seisho.us> ---
The proper syntax in my case Apache/2.4.6 (Linux/SUSE)
is unix:///var/run/php-fpm.sock|fcgi://127.0.0.1:9000/srv/www/$1
With a triple slash, otherwise apache complain of ProxyPass URL must be
absolute!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Tomas van Rijsse <to...@pionect.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomas@pionect.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Eric Covener <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |FixedInTrunk

--- Comment #18 from Eric Covener <co...@gmail.com> ---
(In reply to Jose from comment #17)
> Its a pity we had a patch, it was not implemented into development and now
> it doesn't work anymore.
> 
> Stuck in 2.2.. And trying nginx.

This support has been in trunk/2.5 since early last year.  The patch being
considered for backport to 2.4.x is heree:

http://people.apache.org/~jim/patches/uds-2.4.patch

The latest status on it is here:

https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x/STATUS

Of course, as it ages, there may be cosmetic breakage of the diff.  Any
feedback is welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Sammie S. Taunton <di...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |diemuzi@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Blaise Tarr <bl...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29549|0                           |1
        is obsolete|                            |

--- Comment #1 from Blaise Tarr <bl...@gmail.com> ---
Created attachment 29995
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29995&action=edit
Unix domain socket support for mod_proxy (patch)

I updated my patch to resolve a problem on BSD systems. This patch was
generated against Apache 2.4.4.

Below is my original announcement on the Apache dev mailing list:

The attached patch adds support for Unix domain sockets (UDS) to 
mod_proxy. This is very beneficial when configuring a reverse proxy 
using mod_proxy_fcgi to connect to PHP-FPM. In some tests with ab 
there was over 20% improvement in the request rate when using a UDS 
instead of TCP. 

Since remote servers in mod_proxy are configured with a URL, I took 
the idea from this page on how to represent a UDS as a URL: 
http://daniel.haxx.se/blog/2008/04/14/http-over-unix-domain-sockets/ 

So the host portion of the URL contains "socket=" followed by the URI 
encoded socket path (upper case characters must be encoded too). Below 
are a couple of examples where PHP-FPM's socket is /tmp/php-fpm.sock 
and the document root is /local/htdocs: 

ProxyPass fcgi://socket=%2ftmp%2fphp-fpm.sock/local/htdocs/ 

RewriteRule (.*\.php) fcgi://socket=\%2ftmp\%2fphp-fpm.sock/local/htdocs/$1
[P,L] 

The following are not contained in the patch: 
* bump MMN due to mod_proxy.h changes 
* assign APLOGNO numbers 
* detection of AF_UNIX support in configure 

Thanks for your consideration, 
Blaise

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #22 from me@nileshgr.com ---
(In reply to Francesco from comment #21)
> I did a test and the correct syntax for ProxyPassMatch is
> 
> ProxyPassMatch ^/(.*\.php(/.*)?)$
> unix:/path/to/socket.sock|fcgi://localhost/path/to/docroot/
> 
> The host localhost doesn't really matter, you can put whatever.

That works now. Although if I put $1 (as described at
http://wiki.apache.org/httpd/PHP-FPM), it fails with a 503.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #10 from Peter Boling <pe...@gmail.com> ---
This will allow Phusion Passenger Standalone to be reverse proxied by Apache as
a unix domain socket!  Right now Apache can only reverse proxy over TCP, but
Nginx can reverse proxy to a socket, making it the better performer for Ruby
apps using this setup, and making me jealous, since I have an all Apache
infrastructure.

Any chance of backporting this to 2.2 stable?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

ubunciak <ub...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubunciak@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

glicerinu@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glicerinu@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

nada <ap...@valgronda.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |apache_bugzilla@valgronda.c
                   |                            |om

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #16 from iDen <d....@gmail.com> ---
Hope this will be fixed in some future minor release of 2.4.x
Very crucial for my production env to switch on apache 2.4, but I'm using
PHP-FPM with unix-sockets and definitely won't go with TCP sockets.
Before that's done will stay on apache 2.2 and/or nginx.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #4 from Jim Jagielski <ji...@apache.org> ---
Will fold into trunk for testing and enhancement. Thx

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #5 from phpfpm1@gmail.com ---
Would it be possible to fix it to support RewriteRule in
<Directory></Directory> block (now RewriteRule only works if not in Directory
section, if it is placed in Directory block, then it does not replace %2f to /
well (leaves f instead of /)). Now there is no any other way to use it in
Directory block, because ProxyPassMatch does not work there too
(https://issues.apache.org/bugzilla/show_bug.cgi?id=54616).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Christophe JAILLET <ch...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Pothi Kalimuthu <po...@tinywp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pothi@tinywp.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Blaise Tarr <bl...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |blaise.tarr@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #12 from Marc Zampetti <ma...@zampettis.com> ---
+1 for adding this or similar capability to support PHP-FPM.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #17 from Jose <jb...@ozongo.com> ---
Its a pity we had a patch, it was not implemented into development and now it
doesn't work anymore.

Stuck in 2.2.. And trying nginx.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #20 from Jackie Rosen <ja...@hushmail.com> ---
*** Bug 260998 has been marked as a duplicate of this bug. ***
Seen from the domain http://volichat.com
Page where seen: http://volichat.com/adult-chat-rooms
Marked for reference. Resolved as fixed @bugzilla.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #14 from Sammie S. Taunton <di...@gmail.com> ---
(In reply to me from comment #13)
> Does the patch work on latest 2.4.7 release?
> It hasn't been included, but I can always manually patch it if there are no
> dependencies.

Appears the patch does not work with 2.4.7

patching file mod_proxy.h
Hunk #1 succeeded at 236 (offset 4 lines).
Hunk #2 succeeded at 308 (offset 4 lines).
patching file proxy_util.c
Hunk #2 succeeded at 2028 (offset 7 lines).
Hunk #3 succeeded at 2045 (offset 7 lines).
Hunk #4 FAILED at 2156.
Hunk #5 succeeded at 2403 (offset 19 lines).
Hunk #6 succeeded at 2471 (offset 19 lines).
Hunk #7 succeeded at 2607 (offset 19 lines).
1 out of 7 hunks FAILED -- saving rejects to file proxy_util.c.rej

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #6 from luyanfei78 <lu...@163.com> ---
There's one problem haven't solved by this patch. The function proxy_fcgi_canon
in mod_proxy_fcgi.c will modify proxy url.
fcgi://socket=%2ftmp%2fphp-fpm.sock/local/htdocs/ 
this url will become
fcgi://socket=%2ftmp%2fphp-fpm.sock:8000/local/htdocs/ 
So, it's  important to use nocanon in ProxyPass. If you choose ProxyPassMatch,
then your proxy url will always be changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Christian Kujau <li...@nerdbynature.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lists@nerdbynature.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #9 from ryotakatsuki@gmail.com ---
I see the patch already included in trunk but the part in which the 
PROXY_WORKER_MAX_HOSTNAME_SIZE and PROXY_WORKER_MAX_NAME_SIZE were increased is
not there (I realized that after get a "ProxyPass worker name
(fcgi://uds=%2fsome%2fsocket.sock/tmp/somedirectory too long)"). Was that
dropped intentionally?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #2 from Graham Leggett <mi...@sharp.fm> ---
Not had a chance to review the patch, but a definite +1 in principle.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

Paul Tobias <to...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobias.pal@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 54101] Socket backend support for mod_proxy

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54101

--- Comment #13 from me@nileshgr.com ---
Does the patch work on latest 2.4.7 release?
It hasn't been included, but I can always manually patch it if there are no
dependencies.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org