You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/06 03:34:01 UTC

[jira] [Commented] (AIRFLOW-3635) Fix incorrect logic in delete_dag (introduced in PR #4406)

    [ https://issues.apache.org/jira/browse/AIRFLOW-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735066#comment-16735066 ] 

ASF GitHub Bot commented on AIRFLOW-3635:
-----------------------------------------

XD-DENG commented on pull request #4445: [AIRFLOW-3635] Fix incorrect logic in detele_dag (introduced in PR#4406)
URL: https://github.com/apache/airflow/pull/4445
 
 
   
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-3635
   
   ### Description
   
   Incorrect logic was introduced in PR #4406 (https://github.com/apache/airflow/pull/4406). It's a quite obvious logic error.
   
   This was not found out because the Travis CI was not working as expected.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix incorrect logic in delete_dag (introduced in PR #4406)
> ----------------------------------------------------------
>
>                 Key: AIRFLOW-3635
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3635
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: api
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Critical
>
> Incorrect logic was introduced in PR #4406 ([https://github.com/apache/airflow/pull/4406)]
>  
> This was not found out because the Travis CI was not working as expected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)