You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/03/11 10:27:37 UTC

[GitHub] [commons-vfs] arturobernalg opened a new pull request #164: Avoid File Stream

arturobernalg opened a new pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164


   Use Files.newOutputStream instead of new FileOutputStream (fileName).
   Use Files.newInputStream instead of new FileInputStream (fileName)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] arturobernalg commented on pull request #164: Avoid File Stream

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164#issuecomment-797641760


   > > > What about elsewhere? Like the tests. Should those be updated as well?
   > > 
   > > 
   > > HI @garydgregory
   > > I think it's already cover and not need additional test.What do you think?
   > > https://github.com/apache/commons-vfs/blob/master/commons-vfs2/src/test/java/org/apache/commons/vfs2/ProviderWriteAppendTests.java#L71
   > 
   > @arturobernalg
   > I was not talking about code coverage. I am referring to other call sites, for example `org.apache.commons.vfs2.filter.BaseFilterTest.zipDir(File, FileFilter, String, File)` and others.
   
   Sorry @garydgregory 
   I was not understanding you. Changed
   
   TY


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] arturobernalg commented on pull request #164: Avoid File Stream

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164#issuecomment-796925868


   > What about elsewhere? Like the tests. Should those be updated as well?
   
   HI @garydgregory 
   
   I think it's already cover and not need additional test.What do you think?
   https://github.com/apache/commons-vfs/blob/master/commons-vfs2/src/test/java/org/apache/commons/vfs2/ProviderWriteAppendTests.java#L71
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] garydgregory commented on pull request #164: Avoid File Stream

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164#issuecomment-797617659


   > > What about elsewhere? Like the tests. Should those be updated as well?
   > 
   > HI @garydgregory
   > 
   > I think it's already cover and not need additional test.What do you think?
   > https://github.com/apache/commons-vfs/blob/master/commons-vfs2/src/test/java/org/apache/commons/vfs2/ProviderWriteAppendTests.java#L71
   
   @arturobernalg 
   I have not talking about code coverage. I am referring to other call sites, for example `org.apache.commons.vfs2.filter.BaseFilterTest.zipDir(File, FileFilter, String, File)` and others.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] garydgregory commented on pull request #164: Avoid File Stream

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164#issuecomment-796833935


   Hi @arturobernalg 
   What about elsewhere? Like the tests. Should those be updated as well?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] garydgregory edited a comment on pull request #164: Avoid File Stream

Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164#issuecomment-797617659


   > > What about elsewhere? Like the tests. Should those be updated as well?
   > 
   > HI @garydgregory
   > 
   > I think it's already cover and not need additional test.What do you think?
   > https://github.com/apache/commons-vfs/blob/master/commons-vfs2/src/test/java/org/apache/commons/vfs2/ProviderWriteAppendTests.java#L71
   
   @arturobernalg 
   I was not talking about code coverage. I am referring to other call sites, for example `org.apache.commons.vfs2.filter.BaseFilterTest.zipDir(File, FileFilter, String, File)` and others.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] garydgregory merged pull request #164: Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.

Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org