You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/12 03:55:07 UTC
[GitHub] [rocketmq-apis] drpmma opened a new pull request, #31: Add admin api
drpmma opened a new pull request, #31:
URL: https://github.com/apache/rocketmq-apis/pull/31
Support admin api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] aaron-ai commented on a diff in pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #31:
URL: https://github.com/apache/rocketmq-apis/pull/31#discussion_r871939119
##########
apache/rocketmq/v2/admin.proto:
##########
@@ -38,6 +43,109 @@ message ChangeLogLevelRequest {
message ChangeLogLevelResponse { string remark = 1; }
+message DescribeTopicStatusRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicStatusResponse {
+ Status status = 1;
+ MessageType topic_message_type = 2;
+ optional string description = 3;
+ optional google.protobuf.Timestamp create_timestamp = 4;
+ map<string, string> tags = 5;
+}
+
+message DescribeSubscriptionRequest {
+ optional string instance_id = 1;
+ oneof search_resource {
+ Resource topic = 2;
+ Resource group = 3;
+ }
+}
+
+message DescribeSubscriptionResponse {
+ message SubscriptionInfo {
+ Resource group = 1;
+ Resource topic = 2;
+ FilterExpression expression = 3;
+ bool online = 4;
+ google.protobuf.Timestamp last_update_timestamp = 5;
+ }
+ Status status = 1;
+ repeated SubscriptionInfo subscription_info = 2;
+}
+
+message DescribeGroupAccumulationRequest {
+ optional string instance_id = 1;
+ Resource group = 2;
+ repeated Resource topics = 3;
+}
+
+message DescribeGroupAccumulationResponse {
+ Status status = 1;
+ int64 inflight_messages = 2;
+ int64 ready_messages = 3;
+ int64 accumulation = 4;
+ google.protobuf.Duration deliver_delay_time = 5;
+}
+
+message DescribeConsumerStatusRequest {
+ optional string instance_id = 1;
+ Resource group = 2;
+}
+
+message DescribeConsumerStatusResponse {
+ message ClientInfo {
+ string client_id = 1;
+ string version = 2;
+ string language = 3;
Review Comment:
Maybe we should extract an enumeration to describe language here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui commented on a diff in pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #31:
URL: https://github.com/apache/rocketmq-apis/pull/31#discussion_r870974983
##########
apache/rocketmq/v2/admin.proto:
##########
@@ -38,6 +43,105 @@ message ChangeLogLevelRequest {
message ChangeLogLevelResponse { string remark = 1; }
+message DescribeTopicStatusRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicStatusResponse {
+ Status status = 1;
+ MessageType topic_message_type = 2;
+ string description = 3;
+ google.protobuf.Timestamp create_timestamp = 4;
+ map<string, string> tags = 5;
+}
+
+message DescribeTopicSubscriptionRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicSubscriptionResponse {
+ message SubscriptionInfo {
+ Resource group = 1;
+ FilterExpression expression = 2;
+ bool online = 3;
+ google.protobuf.Timestamp last_update_timestamp = 4;
+ }
+ Status status = 1;
+ repeated SubscriptionInfo subscriptionInfo = 2;
+}
+
+message DescribeConsumerAccumulateRequest {
Review Comment:
Renamed to DescribeGroupRequest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui commented on a diff in pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #31:
URL: https://github.com/apache/rocketmq-apis/pull/31#discussion_r870975293
##########
apache/rocketmq/v2/admin.proto:
##########
@@ -38,6 +43,105 @@ message ChangeLogLevelRequest {
message ChangeLogLevelResponse { string remark = 1; }
+message DescribeTopicStatusRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicStatusResponse {
+ Status status = 1;
+ MessageType topic_message_type = 2;
+ string description = 3;
+ google.protobuf.Timestamp create_timestamp = 4;
+ map<string, string> tags = 5;
+}
+
+message DescribeTopicSubscriptionRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicSubscriptionResponse {
+ message SubscriptionInfo {
+ Resource group = 1;
+ FilterExpression expression = 2;
+ bool online = 3;
+ google.protobuf.Timestamp last_update_timestamp = 4;
+ }
+ Status status = 1;
+ repeated SubscriptionInfo subscriptionInfo = 2;
+}
+
+message DescribeConsumerAccumulateRequest {
+ optional string instance_id = 1;
+ Resource group = 2;
+ repeated Resource topics = 3;
+}
+
+message DescribeConsumerAccumulateResponse {
+ Status status = 1;
Review Comment:
Should have some metrics here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui commented on a diff in pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #31:
URL: https://github.com/apache/rocketmq-apis/pull/31#discussion_r870974764
##########
apache/rocketmq/v2/admin.proto:
##########
@@ -38,6 +43,105 @@ message ChangeLogLevelRequest {
message ChangeLogLevelResponse { string remark = 1; }
+message DescribeTopicStatusRequest {
Review Comment:
DescribeTopicRequest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] drpmma closed pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
drpmma closed pull request #31: Add admin api
URL: https://github.com/apache/rocketmq-apis/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui commented on a diff in pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #31:
URL: https://github.com/apache/rocketmq-apis/pull/31#discussion_r870970201
##########
apache/rocketmq/v2/admin.proto:
##########
@@ -38,6 +43,105 @@ message ChangeLogLevelRequest {
message ChangeLogLevelResponse { string remark = 1; }
+message DescribeTopicStatusRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicStatusResponse {
+ Status status = 1;
+ MessageType topic_message_type = 2;
+ string description = 3;
+ google.protobuf.Timestamp create_timestamp = 4;
+ map<string, string> tags = 5;
+}
+
+message DescribeTopicSubscriptionRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicSubscriptionResponse {
+ message SubscriptionInfo {
+ Resource group = 1;
+ FilterExpression expression = 2;
+ bool online = 3;
+ google.protobuf.Timestamp last_update_timestamp = 4;
+ }
+ Status status = 1;
+ repeated SubscriptionInfo subscriptionInfo = 2;
+}
+
+message DescribeConsumerAccumulateRequest {
+ optional string instance_id = 1;
+ Resource group = 2;
+ repeated Resource topics = 3;
+}
+
+message DescribeConsumerAccumulateResponse {
+ Status status = 1;
+}
+
+message DescribeConsumerStatusRequest {
+ optional string instance_id = 1;
+ Resource group = 2;
+}
+
+message DescribeConsumerStatusResponse {
+ Status status = 1;
+ int64 inflight_messages = 2;
+ int64 ready_messages = 3;
+ int64 accumulation = 4;
+ google.protobuf.Duration deliver_delay_time = 5;
+}
+
+message ResetConsumeOffsetRequest {
Review Comment:
Will ResetGroupOffsetRequest be somewhat more descriptive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] drpmma commented on a diff in pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
drpmma commented on code in PR #31:
URL: https://github.com/apache/rocketmq-apis/pull/31#discussion_r870983470
##########
apache/rocketmq/v2/admin.proto:
##########
@@ -38,6 +43,105 @@ message ChangeLogLevelRequest {
message ChangeLogLevelResponse { string remark = 1; }
+message DescribeTopicStatusRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicStatusResponse {
+ Status status = 1;
+ MessageType topic_message_type = 2;
+ string description = 3;
+ google.protobuf.Timestamp create_timestamp = 4;
+ map<string, string> tags = 5;
+}
+
+message DescribeTopicSubscriptionRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicSubscriptionResponse {
+ message SubscriptionInfo {
+ Resource group = 1;
+ FilterExpression expression = 2;
+ bool online = 3;
+ google.protobuf.Timestamp last_update_timestamp = 4;
+ }
+ Status status = 1;
+ repeated SubscriptionInfo subscriptionInfo = 2;
+}
+
+message DescribeConsumerAccumulateRequest {
+ optional string instance_id = 1;
+ Resource group = 2;
+ repeated Resource topics = 3;
Review Comment:
Group can subscribe to multiple topics, if not specified, return all the topics' accumulation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] drpmma commented on a diff in pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
drpmma commented on code in PR #31:
URL: https://github.com/apache/rocketmq-apis/pull/31#discussion_r870976397
##########
apache/rocketmq/v2/admin.proto:
##########
@@ -38,6 +43,105 @@ message ChangeLogLevelRequest {
message ChangeLogLevelResponse { string remark = 1; }
+message DescribeTopicStatusRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicStatusResponse {
+ Status status = 1;
+ MessageType topic_message_type = 2;
+ string description = 3;
+ google.protobuf.Timestamp create_timestamp = 4;
+ map<string, string> tags = 5;
+}
+
+message DescribeTopicSubscriptionRequest {
Review Comment:
The instance_id is different from the namespace. A instance can have multiple namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui commented on a diff in pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #31:
URL: https://github.com/apache/rocketmq-apis/pull/31#discussion_r870971385
##########
apache/rocketmq/v2/admin.proto:
##########
@@ -38,6 +43,105 @@ message ChangeLogLevelRequest {
message ChangeLogLevelResponse { string remark = 1; }
+message DescribeTopicStatusRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicStatusResponse {
+ Status status = 1;
+ MessageType topic_message_type = 2;
+ string description = 3;
+ google.protobuf.Timestamp create_timestamp = 4;
+ map<string, string> tags = 5;
+}
+
+message DescribeTopicSubscriptionRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicSubscriptionResponse {
+ message SubscriptionInfo {
+ Resource group = 1;
+ FilterExpression expression = 2;
+ bool online = 3;
+ google.protobuf.Timestamp last_update_timestamp = 4;
+ }
+ Status status = 1;
+ repeated SubscriptionInfo subscriptionInfo = 2;
+}
+
+message DescribeConsumerAccumulateRequest {
+ optional string instance_id = 1;
+ Resource group = 2;
+ repeated Resource topics = 3;
+}
+
+message DescribeConsumerAccumulateResponse {
+ Status status = 1;
+}
+
+message DescribeConsumerStatusRequest {
+ optional string instance_id = 1;
+ Resource group = 2;
+}
+
+message DescribeConsumerStatusResponse {
+ Status status = 1;
+ int64 inflight_messages = 2;
+ int64 ready_messages = 3;
+ int64 accumulation = 4;
+ google.protobuf.Duration deliver_delay_time = 5;
+}
+
+message ResetConsumeOffsetRequest {
+ optional string instance_id = 1;
+ Resource group = 2;
+ Resource topic = 3;
+ google.protobuf.Timestamp reset_timestamp = 4;
+}
+
+message ResetConsumeOffsetResponse {
+ Status status = 1;
+}
+
+message QueryMessageByIdRequest {
Review Comment:
Will it be feasible to combine QueryMessageByIdRequest and QueryMessageByKeyRequest by having QueryMessageRequest and conducting actual queries based on what is provided in the optional fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui commented on a diff in pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #31:
URL: https://github.com/apache/rocketmq-apis/pull/31#discussion_r870973837
##########
apache/rocketmq/v2/admin.proto:
##########
@@ -38,6 +43,105 @@ message ChangeLogLevelRequest {
message ChangeLogLevelResponse { string remark = 1; }
+message DescribeTopicStatusRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicStatusResponse {
+ Status status = 1;
+ MessageType topic_message_type = 2;
+ string description = 3;
+ google.protobuf.Timestamp create_timestamp = 4;
+ map<string, string> tags = 5;
+}
+
+message DescribeTopicSubscriptionRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicSubscriptionResponse {
+ message SubscriptionInfo {
+ Resource group = 1;
+ FilterExpression expression = 2;
+ bool online = 3;
+ google.protobuf.Timestamp last_update_timestamp = 4;
+ }
+ Status status = 1;
+ repeated SubscriptionInfo subscriptionInfo = 2;
+}
+
+message DescribeConsumerAccumulateRequest {
+ optional string instance_id = 1;
+ Resource group = 2;
+ repeated Resource topics = 3;
Review Comment:
topics may not be necessary because brokers should have this knowledge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui commented on a diff in pull request #31: Add admin api
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #31:
URL: https://github.com/apache/rocketmq-apis/pull/31#discussion_r870972791
##########
apache/rocketmq/v2/admin.proto:
##########
@@ -38,6 +43,105 @@ message ChangeLogLevelRequest {
message ChangeLogLevelResponse { string remark = 1; }
+message DescribeTopicStatusRequest {
+ optional string instance_id = 1;
+ Resource topic = 2;
+}
+
+message DescribeTopicStatusResponse {
+ Status status = 1;
+ MessageType topic_message_type = 2;
+ string description = 3;
+ google.protobuf.Timestamp create_timestamp = 4;
+ map<string, string> tags = 5;
+}
+
+message DescribeTopicSubscriptionRequest {
Review Comment:
Why instance_id is still necessary as "topic" itself is already namespaced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org