You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "tao12345666333 (via GitHub)" <gi...@apache.org> on 2023/05/08 07:52:35 UTC
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #528: feat: allow proxy protocol configuration for APISIX
tao12345666333 commented on code in PR #528:
URL: https://github.com/apache/apisix-helm-chart/pull/528#discussion_r1187139221
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -69,14 +69,16 @@ data:
enable_ipv6: {{ .Values.apisix.enableIPv6 }} # Enable nginx IPv6 resolver
enable_server_tokens: {{ .Values.apisix.enableServerTokens }} # Whether the APISIX version number should be shown in Server header
- # proxy_protocol: # Proxy Protocol configuration
- # listen_http_port: 9181 # The port with proxy protocol for http, it differs from node_listen and admin_listen.
- # # This port can only receive http request with proxy protocol, but node_listen & admin_listen
- # # can only receive http request. If you enable proxy protocol, you must use this port to
- # # receive http request with proxy protocol
- # listen_https_port: 9182 # The port with proxy protocol for https
- # enable_tcp_pp: true # Enable the proxy protocol for tcp proxy, it works for stream_proxy.tcp option
- # enable_tcp_pp_to_upstream: true # Enables the proxy protocol to the upstream server
+ {{- if .Values.apisix.proxyProtocol.enabled }}
+ proxy_protocol: # Proxy Protocol configuration
+ listen_http_port: {{ .Values.apisix.proxyProtocol.listenHttpPort }} # The port with proxy protocol for http, it differs from node_listen and port_admin.
+ # This port can only receive http request with proxy protocol, but node_listen & port_admin
+ # can only receive http request. If you enable proxy protocol, you must use this port to
+ # receive http request with proxy protocol
+ listen_https_port: {{ .Values.apisix.proxyProtocol.listenHttpsPort }} # The port with proxy protocol for https
+ enable_tcp_pp: {{ .Values.apisix.proxyProtocol.enabled }} # Enable the proxy protocol for tcp proxy, it works for stream_proxy.tcp option
Review Comment:
we can use a new configuration item
##########
charts/apisix/Chart.yaml:
##########
@@ -31,7 +31,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 1.3.1
+version: 1.4.0
Review Comment:
we can just bump to 1.3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org