You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lucasbru (via GitHub)" <gi...@apache.org> on 2025/12/11 13:57:39 UTC

[PR] KAFKA-19985: Document streams groups metrics changes in ops.html [kafka]

lucasbru opened a new pull request, #21129:
URL: https://github.com/apache/kafka/pull/21129

   Added documentation for KIP-1071 broker metrics:
   - Extended group-count metric to include protocol=streams
   - Added streams-group-count metric with states: empty, not_ready, assigning, reconciling, stable, dead
   - Added streams-group-rebalance-rate and streams-group-rebalance-count metrics
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-19985: Document streams groups metrics changes in ops.html [kafka]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #21129:
URL: https://github.com/apache/kafka/pull/21129#discussion_r2610698265


##########
docs/ops.html:
##########
@@ -1955,6 +1955,21 @@ <h4 class="anchor-heading"><a id="group_coordinator_monitoring" class="anchor-li
       <td>kafka.server:type=group-coordinator-metrics,name=consumer-group-rebalance-count</td>
       <td>Total number of Consumer Group Rebalances</td>
     </tr>
+    <tr>
+      <td>Streams Group Count, per state</td>
+      <td>kafka.server:type=group-coordinator-metrics,name=streams-group-count,state=[empty|not_ready|assigning|reconciling|stable|dead]</td>
+      <td>Total number of Streams Groups in each state: Empty, Not Ready, Assigning, Reconciling, Stable, Dead</td>
+    </tr>
+    <tr>
+      <td>Streams Group Rebalance Rate</td>
+      <td>kafka.server:type=group-coordinator-metrics,name=streams-group-rebalance-rate</td>
+      <td>The rebalance rate of streams groups</td>

Review Comment:
   The description for "streams-group-rebalance-rate" uses lowercase "streams groups" while the similar metric "consumer-group-rebalance-rate" on line 1951 uses lowercase "consumer groups". However, the "Streams Group Rebalance Count" description on line 1971 uses title case "Streams Group". For consistency with the similar "Consumer Group" metrics pattern (where line 1956 uses title case "Consumer Group Rebalances"), this should use title case "Streams Groups" to match line 1971 and the pattern established by consumer group metrics.
   ```suggestion
         <td>The rebalance rate of Streams Groups</td>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-19985: Document streams groups metrics changes in ops.html [kafka]

Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on PR #21129:
URL: https://github.com/apache/kafka/pull/21129#issuecomment-3654905758

   picked to 4.2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-19985: Document streams groups metrics changes in ops.html [kafka]

Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru merged PR #21129:
URL: https://github.com/apache/kafka/pull/21129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org