You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/08/15 07:00:51 UTC
Review Request 61650: Controlled queued task handling with helpers in
the agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61650/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
With this patch, the enqueueing and dequeueing of tasks in the
agent are controlled solely by Executor class member functions,
which simplifies the agent code.
Diffs
-----
src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79
src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b
Diff: https://reviews.apache.org/r/61650/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 61650: Controlled queued task handling with
helpers in the agent.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61650/#review183679
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.hpp
Line 714 (original), 715 (patched)
<https://reviews.apache.org/r/61650/#comment259748>
s/will/will also/
- Vinod Kone
On Aug. 23, 2017, 9:29 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61650/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2017, 9:29 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this patch, the enqueueing and dequeueing of tasks in the
> agent are controlled solely by Executor class member functions,
> which simplifies the agent code.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 0e07a1af733003bb897cbebb7c1f64437063353d
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
>
>
> Diff: https://reviews.apache.org/r/61650/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 61650: Controlled queued task handling with
helpers in the agent.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61650/
-----------------------------------------------------------
(Updated Aug. 23, 2017, 9:29 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
Addressed review comments.
Repository: mesos
Description
-------
With this patch, the enqueueing and dequeueing of tasks in the
agent are controlled solely by Executor class member functions,
which simplifies the agent code.
Diffs (updated)
-----
src/slave/slave.hpp 0e07a1af733003bb897cbebb7c1f64437063353d
src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
Diff: https://reviews.apache.org/r/61650/diff/2/
Changes: https://reviews.apache.org/r/61650/diff/1-2/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 61650: Controlled queued task handling with
helpers in the agent.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61650/#review183558
-----------------------------------------------------------
Thanks for all the cleanup!
- Vinod Kone
On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61650/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 7 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this patch, the enqueueing and dequeueing of tasks in the
> agent are controlled solely by Executor class member functions,
> which simplifies the agent code.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79
> src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b
>
>
> Diff: https://reviews.apache.org/r/61650/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 61650: Controlled queued task handling with
helpers in the agent.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61650/#review183556
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.hpp
Lines 715 (patched)
<https://reviews.apache.org/r/61650/#comment259578>
Can you add a comment that this also adds the task to queued tasks?
src/slave/slave.cpp
Lines 2399 (patched)
<https://reviews.apache.org/r/61650/#comment259576>
s/task/tasks/
src/slave/slave.cpp
Lines 2619 (patched)
<https://reviews.apache.org/r/61650/#comment259577>
can you log the task or taskgroup for debugging?
- Vinod Kone
On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61650/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 7 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this patch, the enqueueing and dequeueing of tasks in the
> agent are controlled solely by Executor class member functions,
> which simplifies the agent code.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79
> src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b
>
>
> Diff: https://reviews.apache.org/r/61650/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 61650: Controlled queued task handling with
helpers in the agent.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61650/#review182931
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61639, 61640, 61641, 61642, 61643, 61644, 61645, 61646, 61647, 61648, 61649, 61638, 61650]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61650/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 7 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this patch, the enqueueing and dequeueing of tasks in the
> agent are controlled solely by Executor class member functions,
> which simplifies the agent code.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79
> src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b
>
>
> Diff: https://reviews.apache.org/r/61650/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>