You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Gilles Sadowski (Jira)" <ji...@apache.org> on 2020/06/06 21:52:00 UTC

[jira] [Commented] (MATH-1538) refine some codes dealing with filling an array with its first and second elements.

    [ https://issues.apache.org/jira/browse/MATH-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127435#comment-17127435 ] 

Gilles Sadowski commented on MATH-1538:
---------------------------------------

Do I understand correctly that this PR replaces an array access with one logical operation and one boolean check?
Did you benchmark this with a realistic use-case (i.e. within the class where this change is proposed)?  In the {{Logit}} case at least, my impression that any performance gain would be quite small since it only appears in the edge case.

> refine some codes dealing with filling an array with its first and second elements.
> -----------------------------------------------------------------------------------
>
>                 Key: MATH-1538
>                 URL: https://issues.apache.org/jira/browse/MATH-1538
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Jin Xu
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> [https://github.com/apache/commons-math/pull/144]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)