You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Karl Pauls (JIRA)" <ji...@apache.org> on 2019/06/07 11:27:00 UTC

[jira] [Commented] (SLING-8430) Use java.util.zip.ZipFile in Feature Model Analyser

    [ https://issues.apache.org/jira/browse/SLING-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858523#comment-16858523 ] 

Karl Pauls commented on SLING-8430:
-----------------------------------

[~hsaginor@gmail.com], I added a couple of comments to your PR - could you try to address them? Thanks for providing the patch!

> Use java.util.zip.ZipFile in Feature Model Analyser
> ---------------------------------------------------
>
>                 Key: SLING-8430
>                 URL: https://issues.apache.org/jira/browse/SLING-8430
>             Project: Sling
>          Issue Type: Improvement
>          Components: Feature Model
>            Reporter: Henry Saginor
>            Assignee: Karl Pauls
>            Priority: Minor
>
> The ContentPackageScanner and FelixFrameworkScanner could use java.util.zip.ZipFile API. In my estimation this should improve performance over the current use of ZipInputStream.
> Here is a pull request with suggested changes including a unit test for ContentPackageScanner:
> https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/14



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)