You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "timsaucer (via GitHub)" <gi...@apache.org> on 2025/04/25 18:52:37 UTC
[PR] Move the udf module to user_defined [datafusion-python]
timsaucer opened a new pull request, #1112:
URL: https://github.com/apache/datafusion-python/pull/1112
# Which issue does this PR close?
None
# Rationale for this change
Right now we have some minor confusion when importing from the `udf` module because at the root of `datafusion` we also have a `udf` method. This is a minor inconvenience, but it has shown up a few times where a user wants to import one or the other. This removes the uncertainty by changing the `udf` module to `user_defined.` Also since this module includes scalar, aggregate, and window functions it is a cleaner organization.
# What changes are included in this PR?
- Move the `datafusion.udf` module to `datafusion.user_defined`. **This is a breaking change**. Fortunately most historical users have been using the helper functions which exist in the root module.
- Correct documentation build errors. Specifically there were examples in markdown instead of rst format.
- Update the text of the UDF documentation to be more consistent with other portions of the code base.
# Are there any user-facing changes?
Users will need to update their module imports from `datafusion.udf` to `datafusion.user_defined`. The `datafusion.udf` function is NOT impacted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Move the udf module to user_defined [datafusion-python]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on PR #1112:
URL: https://github.com/apache/datafusion-python/pull/1112#issuecomment-2831187602
@crystalxyz FYI this does touch on the documentation you wrote. Please let me know if you think I should change back the formatting. I did need to switch from markdown to rst format for our documentation build system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Move the udf module to user_defined [datafusion-python]
Posted by "crystalxyz (via GitHub)" <gi...@apache.org>.
crystalxyz commented on PR #1112:
URL: https://github.com/apache/datafusion-python/pull/1112#issuecomment-2833418001
@timsaucer The documentation changes look good to me! Do you think that adding a comment in `python/datafusion/user_defined` to explain the renaming would be helpful? People reading this file might get confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Move the udf module to user_defined [datafusion-python]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer merged PR #1112:
URL: https://github.com/apache/datafusion-python/pull/1112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org