You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 15:14:27 UTC
[GitHub] [airflow] jmcarp opened a new pull request #12951: Discussion: Use plain asserts in core tests.
jmcarp opened a new pull request #12951:
URL: https://github.com/apache/airflow/pull/12951
We have talked about switching from unittest-style assertions (like `self.assertEqual(foo, bar)`) to plain pytest-style assertions (like `assert foo == bar`) on slack and the mailing list, but it doesn't seem like we've decided so far. I wanted to send a sample PR to show how this might work. I generated these changes with a one-line command:
```
unittest2pytest -f self_assert tests/core -w
```
If we try to refactor many tests at once, we'll likely run into conflicts, but because we can auto-refactor the code easily, fixing conflicts should be straightforward too.
Note that I didn't use the `remove_class` fixer or move test setup into fixtures--this just concerns assertion style.
Does this seem like an improvement? If so, we can refactor tests module by module, or run `unittest2pytest` on all the tests at once.
cc @ashb @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
jmcarp commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-758054997
Rebased. The last failing tests I saw seemed random and unrelated to these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
jmcarp commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-753656275
I'll continue fixing merge conflicts now and then, but this is ready for review. I see that our testing docs already recommend using plain asserts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
jmcarp commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-754155245
Rebased. Is it ok for the heisentests to fail or should I rerun?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-760596841
[The Workflow run](https://github.com/apache/airflow/actions/runs/486848941) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-759876701
[The Workflow run](https://github.com/apache/airflow/actions/runs/484301994) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-761853055
Yeah. There Was an extra space (!) added in setup.cfg but it has been fixed since :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-761853158
Thanks for your patience @jmcarp! :) The CI problems did not make it easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Discussion: Use plain asserts in core tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-741888552
[The Workflow run](https://github.com/apache/airflow/actions/runs/410896942) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Discussion: Use plain asserts in core tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-741888081
[The Workflow run](https://github.com/apache/airflow/actions/runs/411055101) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-760445630
[The Workflow run](https://github.com/apache/airflow/actions/runs/486036120) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Discussion: Use plain asserts in core tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-751813449
[The Workflow run](https://github.com/apache/airflow/actions/runs/449284287) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-757563003
[The Workflow run](https://github.com/apache/airflow/actions/runs/476353627) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-757423538
[The Workflow run](https://github.com/apache/airflow/actions/runs/475072791) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
jmcarp commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-761702701
Ok, I think tests are in good shape and the failures are random (quarantined tests) or a formatting regression in setup.cfg that's already in the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp commented on pull request #12951: Discussion: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
jmcarp commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-751926285
Now that airflow 2.0 is out (congratulations!) I'm going to mark this ready for review. This is obviously going to accumulate merge conflicts, but they'll be straightforward to resolve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Discussion: Use plain asserts in core tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-751765821
[The Workflow run](https://github.com/apache/airflow/actions/runs/449105630) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Discussion: Use plain asserts in core tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-751387154
[The Workflow run](https://github.com/apache/airflow/actions/runs/445924067) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-759261955
There's an error which seems to be present in multiple builds, so I think we should take a look at that:
```
tests/core/test_configuration.py:518:
915
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
916
917
self = <tests.test_utils.reset_warning_registry.reset_warning_registry object at 0x7f0b78239f50>
918
919
def __enter__(self):
920
# archive and clear the __warningregistry__ key for all modules
921
# that match the 'reset' pattern.
922
pattern = self._pattern
923
backup = self._backup = {}
924
for name, mod in list(sys.modules.items()):
925
if pattern.match(name):
926
reg = getattr(mod, "__warningregistry__", None)
927
if reg:
928
> backup[name] = reg.copy()
929
E AttributeError: 'str' object has no attribute 'copy'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Discussion: Use plain asserts in core tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-751790897
[The Workflow run](https://github.com/apache/airflow/actions/runs/449198495) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-753791007
@potiuk @kaxil @ashb @turbaszek WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-759973300
Hey @jmcarp -> I had to cancel this run because of this random GitHub error https://github.com/apache/airflow/runs/1699834461?check_suite_focus=true#step:10:310
Can you please --amend/push again?
BTW. We have a meeting today with INFRA and GitHub developer advocate https://cwiki.apache.org/confluence/display/INFRA/ASF+Builds+Agenda+2021-01-14, as this is releted to erratic behaviour of Github Registry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Discussion: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-752663127
[The Workflow run](https://github.com/apache/airflow/actions/runs/452881573) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-757563111
[The Workflow run](https://github.com/apache/airflow/actions/runs/476328819) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12951:
URL: https://github.com/apache/airflow/pull/12951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-760502911
[The Workflow run](https://github.com/apache/airflow/actions/runs/486365169) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Discussion: Use plain asserts in core tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-751302005
[The Workflow run](https://github.com/apache/airflow/actions/runs/444767304) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp commented on pull request #12951: Discussion: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
jmcarp commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-752281578
@turbaszek we could include `unittest2pytest` in ci, but there's a bug in python 3.6 that causes it to fail on raw fstrings. So we could:
* Only run `unittest2pytest` in python>3.6
* Write a regex
* Document that we prefer plain assertions without enforcing programmatically. I'm guessing most people are going to copy and paste tests from existing modules, so we might not have many regressions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12951: Discussion: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-752019107
Will it be possible to automate checking that we do not use `self.assert`? It would be good to avoid regression
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
jmcarp commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-757501583
I'm marking that test as quarantined. It passes locally, and behavior seems inconsistent from CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12951: Discussion: Use plain asserts in core tests.
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-741895929
Thanks @jmcarp for the PR!
> doesn't seem like we've decided so far
We've reached consensus that we prefer `assert x == y` but it was postponed until we release and stabilise Airflow 2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-761690896
[The Workflow run](https://github.com/apache/airflow/actions/runs/490708541) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-753937986
@jmcarp would you mind rebasing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-753805782
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
jmcarp commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-755580148
Resolved some more conflicts. @mik-laj @turbaszek is this ok to merge once tests are passing, or should we figure out the heisentests first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Discussion: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-753438106
[The Workflow run](https://github.com/apache/airflow/actions/runs/457261373) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12951: Discussion: Use plain asserts in core tests.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-751813640
[The Workflow run](https://github.com/apache/airflow/actions/runs/449245551) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12951: Use plain asserts in tests.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12951:
URL: https://github.com/apache/airflow/pull/12951#issuecomment-757468374
The failed test is https://github.com/apache/airflow/pull/12951/checks?check_run_id=1675678142#step:6:890 - looking at it, I think it either should be moved to quarantine or fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org