You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "umustafi (via GitHub)" <gi...@apache.org> on 2023/08/31 19:53:33 UTC

[GitHub] [gobblin] umustafi opened a new pull request, #3757: [GOBBLIN1893] Upgrade Guava to 21.0.0

umustafi opened a new pull request, #3757:
URL: https://github.com/apache/gobblin/pull/3757

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1893
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if applicable):
   Upgrade Guava from version 20.0.0 to 21.0.0 and resolve build errors resulting from deprecated method removed in version 21. 
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Needs to be further tested at runtime
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [gobblin] Will-Lo merged pull request #3757: [GOBBLIN1893] Upgrade Guava to 21.0.0

Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3757:
URL: https://github.com/apache/gobblin/pull/3757


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [gobblin] codecov-commenter commented on pull request #3757: [GOBBLIN1893] Upgrade Guava to 21.0.0

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3757:
URL: https://github.com/apache/gobblin/pull/3757#issuecomment-1701726857

   ## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3757?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#3757](https://app.codecov.io/gh/apache/gobblin/pull/3757?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (65255b6) into [master](https://app.codecov.io/gh/apache/gobblin/commit/0ab094a4277b92e17c46b3722b603daaf126d022?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0ab094a) will **decrease** coverage by `11.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3757       +/-   ##
   =============================================
   - Coverage     47.07%   36.08%   -11.00%     
   + Complexity    10874     1482     -9392     
   =============================================
     Files          2147      383     -1764     
     Lines         84915    15667    -69248     
     Branches       9420     1538     -7882     
   =============================================
   - Hits          39977     5653    -34324     
   + Misses        41302     9561    -31741     
   + Partials       3636      453     -3183     
   ```
   
   
   [see 1764 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3757/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org