You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/11/09 16:26:00 UTC
[jira] [Commented] (HIVE-20849) Review of
ConstantPropagateProcFactory
[ https://issues.apache.org/jira/browse/HIVE-20849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681666#comment-16681666 ]
Hive QA commented on HIVE-20849:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12947443/HIVE-20849.1.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14835/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14835/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14835/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-11-09 16:24:52.582
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-14835/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-11-09 16:24:52.585
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 01cef92 HIVE-20881: Constant propagation oversimplifies projections (Zoltan Haindrich reviewed by Ashutosh Chauhan)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 01cef92 HIVE-20881: Constant propagation oversimplifies projections (Zoltan Haindrich reviewed by Ashutosh Chauhan)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-11-09 16:24:53.149
+ rm -rf ../yetus_PreCommit-HIVE-Build-14835
+ mkdir ../yetus_PreCommit-HIVE-Build-14835
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-14835
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-14835/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch
error: a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java: does not exist in index
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java:63
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java' with conflicts.
Going to apply patch with: git apply -p1
/data/hiveptest/working/scratch/build.patch:234: trailing whitespace.
return (udf.getClass().equals(GenericUDFUnixTimeStamp.class)
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java:63
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java' with conflicts.
U ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
warning: 1 line adds whitespace errors.
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-14835
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12947443 - PreCommit-HIVE-Build
> Review of ConstantPropagateProcFactory
> --------------------------------------
>
> Key: HIVE-20849
> URL: https://issues.apache.org/jira/browse/HIVE-20849
> Project: Hive
> Issue Type: Improvement
> Components: Logical Optimizer
> Affects Versions: 3.1.0, 4.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HIVE-20849.1.patch, HIVE-20849.1.patch
>
>
> I was looking at this class because it blasts a lot of useless (to an admin) information to the logs. Especially if the table has a lot of columns, I see big blocks of logging that are meaningless to me. I request that the logging is toned down to debug, and some other improvements to the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)