You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by ma...@apache.org on 2022/07/25 18:06:46 UTC

[ranger] 11/28: RANGER-3807: getUserRoles API gives 200 for non existing user passed to this API

This is an automated email from the ASF dual-hosted git repository.

madhan pushed a commit to branch ranger-2.4
in repository https://gitbox.apache.org/repos/asf/ranger.git

commit 9261b6e19dfbaace370fc939e458de0e783bca08
Author: pradeep <pr...@apache.org>
AuthorDate: Fri Jun 24 16:40:46 2022 +0530

    RANGER-3807: getUserRoles API gives 200 for non existing user passed to this API
    
    (cherry picked from commit d247fece1055555d926b4487cfd43fcefedad94c)
---
 security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java b/security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java
index 8478104a8..d8771a98e 100644
--- a/security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java
+++ b/security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java
@@ -698,6 +698,9 @@ public class RoleREST {
             LOG.debug("==> getUserRoles()");
         }
         try {
+            if (xUserService.getXUserByUserName(userName) == null) {
+                throw restErrorUtil.createRESTException(HttpServletResponse.SC_NOT_FOUND, "User:" + userName + " not found", false);
+            }
             Set<RangerRole> roleList = roleStore.getRoleNames(userName, userMgr.getGroupsForUser(userName));
             for (RangerRole role : roleList) {
                 ret.add(role.getName());