[GitHub] [pulsar] merlimat commented on pull request #15442: [C++] Link with protobuf-lite to reduce binary size

[GitBox <gi...@apache.org>]

merlimat commented on PR #15442:
URL: https://github.com/apache/pulsar/pull/15442#issuecomment-1119098807

   > I think we should still keep the regular protobuf version to support protobuf native schema. The lite version doesn't support serializing to or from `google::protobuf::Descriptor`.
   
   Uhm, I think there's a problem with the way the descriptor is currently exposed. In the dynamic library, we're generally including all the dependencies, in order to create a dependency-less libpulsar.so. All the symbols of the dependencies are hidden inside, to avoid conflict with other versions of same libraries. 
   
   I believe that in many cases, this would not be working: 
   
   ```cpp
   PULSAR_PUBLIC SchemaInfo createProtobufNativeSchema(const google::protobuf::Descriptor* descriptor);
   ```
   
   because the `Descriptor` symbol is hidden and not accessible from the application code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org