You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xushiyan (via GitHub)" <gi...@apache.org> on 2023/01/28 22:38:41 UTC

[GitHub] [hudi] xushiyan opened a new pull request, #7785: [HUDI-5638] Fix metaserver test setup

xushiyan opened a new pull request, #7785:
URL: https://github.com/apache/hudi/pull/7785

   ### Change Logs
   
   - Make module tests passing in CI.
   - Make `hudi-platform-service` profile activated under `-DdeployArtifacts`
   
   ### Impact
   
   Fix tests and artifact deployment for metaserver.
   
   ### Risk level
   
   Medium. 
   
   - [ ] Validate via deploy script to have metaserver bundle generated properly.
   
   ### Documentation Update
   
   NA
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7785: [HUDI-5638] Fix metaserver test setup

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7785:
URL: https://github.com/apache/hudi/pull/7785#issuecomment-1407509099

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "267f5d56a96a0fb917036ffe7a41fb707c81fe94",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "267f5d56a96a0fb917036ffe7a41fb707c81fe94",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 267f5d56a96a0fb917036ffe7a41fb707c81fe94 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua merged pull request #7785: [HUDI-5638] Fix metaserver test setup

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #7785:
URL: https://github.com/apache/hudi/pull/7785


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #7785: [HUDI-5638] Fix metaserver test setup

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #7785:
URL: https://github.com/apache/hudi/pull/7785#discussion_r1089872965


##########
azure-pipelines.yml:
##########
@@ -85,7 +85,7 @@ parameters:
 variables:
   BUILD_PROFILES: '-Dscala-2.11 -Dspark2.4 -Dflink1.16'
   PLUGIN_OPTS: '-Dcheckstyle.skip=true -Drat.skip=true -Djacoco.skip=true -ntp -B -V -Pwarn-log -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=warn -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.dependency=warn'
-  MVN_OPTS_INSTALL: '-DskipTests $(BUILD_PROFILES) $(PLUGIN_OPTS)'
+  MVN_OPTS_INSTALL: '-Phudi-platform-service -DskipTests $(BUILD_PROFILES) $(PLUGIN_OPTS)'

Review Comment:
   Shall we include this module by default?  We already have enough profiles and let's not add a new one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #7785: [HUDI-5638] Fix metaserver test setup

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #7785:
URL: https://github.com/apache/hudi/pull/7785#discussion_r1089874363


##########
azure-pipelines.yml:
##########
@@ -85,7 +85,7 @@ parameters:
 variables:
   BUILD_PROFILES: '-Dscala-2.11 -Dspark2.4 -Dflink1.16'
   PLUGIN_OPTS: '-Dcheckstyle.skip=true -Drat.skip=true -Djacoco.skip=true -ntp -B -V -Pwarn-log -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=warn -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.dependency=warn'
-  MVN_OPTS_INSTALL: '-DskipTests $(BUILD_PROFILES) $(PLUGIN_OPTS)'
+  MVN_OPTS_INSTALL: '-Phudi-platform-service -DskipTests $(BUILD_PROFILES) $(PLUGIN_OPTS)'

Review Comment:
   Synced offline.  This is due to the limitation of Thrift code generation.  We have to live with it now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7785: [HUDI-5638] Fix metaserver test setup

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7785:
URL: https://github.com/apache/hudi/pull/7785#issuecomment-1407510099

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "267f5d56a96a0fb917036ffe7a41fb707c81fe94",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14732",
       "triggerID" : "267f5d56a96a0fb917036ffe7a41fb707c81fe94",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 267f5d56a96a0fb917036ffe7a41fb707c81fe94 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14732) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7785: [HUDI-5638] Fix metaserver test setup

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7785:
URL: https://github.com/apache/hudi/pull/7785#issuecomment-1407538356

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "267f5d56a96a0fb917036ffe7a41fb707c81fe94",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14732",
       "triggerID" : "267f5d56a96a0fb917036ffe7a41fb707c81fe94",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 267f5d56a96a0fb917036ffe7a41fb707c81fe94 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14732) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org