[GitHub] [incubator-iceberg] arina-ielchiieva commented on a change in pull request #302: Support write mode for Parquet and Avro using table property

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #302: Support write mode for Parquet and Avro using table property
URL: https://github.com/apache/incubator-iceberg/pull/302#discussion_r306028946
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/TableProperties.java
 ##########
 @@ -56,9 +56,15 @@ private TableProperties() {}
   public static final String PARQUET_COMPRESSION = "write.parquet.compression-codec";
   public static final String PARQUET_COMPRESSION_DEFAULT = "gzip";
 
+  public static final String PARQUET_WRITE_MODE = "write.parquet.write-mode";
+  public static final String PARQUET_WRITE_MODE_DEFAULT = "overwrite";
 
 Review comment:
   For Parquet - yes, initially it was `overwrite`. For Avro - no, initially it was `create`. I made both `overwrite` to be the same but I can default Avro to `create`  for backward compatibility if needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org