You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by ztao1987 <gi...@git.apache.org> on 2016/05/18 10:22:32 UTC
[GitHub] incubator-hawq pull request: HAWQ-740. Fix bug in SQLUtility.
GitHub user ztao1987 opened a pull request:
https://github.com/apache/incubator-hawq/pull/662
HAWQ-740. Fix bug in SQLUtility.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ztao1987/incubator-hawq HAWQ-740
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/662.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #662
----
commit 787ecfcef017c37ea17b9dd6f3fda8da694f7e97
Author: ztao1987 <zh...@gmail.com>
Date: 2016-05-18T10:22:05Z
HAWQ-740. Fix bug in SQLUtility.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-740. Fix bug in SQLUtility.
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/662#issuecomment-220213835
+1 Overall it is good, except that a more meaningful name instead of execute1 would be better
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-740. Fix bug in SQLUtility.
Posted by ztao1987 <gi...@git.apache.org>.
Github user ztao1987 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/662#issuecomment-220215347
used void execute(const std::string &sql, bool check = true) instead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-740. Fix bug in SQLUtility.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---