Re: [PR] MINOR: Change KStreamKstreamOuterJoinTest to use distinct left and right types [kafka]

["cadonna (via GitHub)" <gi...@apache.org>]

cadonna commented on code in PR #15513:
URL: https://github.com/apache/kafka/pull/15513#discussion_r1617320224


##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java:
##########
@@ -737,12 +739,12 @@ public void runOuterJoin(final StreamJoined<Integer, String, String> streamJoine
                 inputTopic1.pipeInput(expectedKey, "C" + expectedKey);
             }
             processor.checkAndClearProcessResult(
-                new KeyValueTimestamp<>(0, "C0+a0", 0L),
-                new KeyValueTimestamp<>(0, "C0+b0", 0L),
-                new KeyValueTimestamp<>(1, "C1+a1", 0L),
-                new KeyValueTimestamp<>(1, "C1+b1", 0L),
-                new KeyValueTimestamp<>(2, "C2+b2", 0L),
-                new KeyValueTimestamp<>(3, "C3+b3", 0L)
+                new KeyValueTimestamp<>(0, "C0+0", 0L),
+                new KeyValueTimestamp<>(0, "C0+0", 0L),
+                new KeyValueTimestamp<>(1, "C1+1", 0L),
+                new KeyValueTimestamp<>(1, "C1+1", 0L),

Review Comment:
   This seems to make the verification less strict. It does not differentiate between `a0` and `b0` as well as `a1` and `b1`. Maybe use `10` for `a0` and `20` for `b0` and `11` for `a1` and `21` for `b1`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org