You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/01 08:19:34 UTC
[GitHub] zhztheplayer commented on issue #1075: [CALCITE-2881] Add the
JSON_PRETTY function
zhztheplayer commented on issue #1075: [CALCITE-2881] Add the JSON_PRETTY function
URL: https://github.com/apache/calcite/pull/1075#issuecomment-468582585
@ritesh-kapoor I've leaved some comments in the PR, and I suggest some extra changes:
- As per MySQL's standard[1], please make the keyword JSON_PRETTY non-reserved.
- Add `JSON_PRETTY ` to list `nonReservedKeywords` in /root/Documents/SourceCode/calcite/babel/src/main/codegen/config.fmpp;
- Add `JSON_PRETTY ` to list `nonReservedKeywords` in /root/Documents/SourceCode/calcite/core/src/main/codegen/config.fmpp;
- Add `JSON_PRETTY ` to list `nonReservedKeywords` in /root/Documents/SourceCode/calcite/core/src/test/codegen/config.fmpp;
- Add `JSON_PRETTY ` to list `nonReservedKeywords` in /root/Documents/SourceCode/calcite/server/src/main/codegen/config.fmpp;
- Revert your changes about keywords in SqlAdvisorTest and SqlParserTest;
- Change `**JSON_PRETTY **` to `JSON_PRETTY` from reference.md.
- Also please add some bad cases into `SqlOperatorBaseTest` and `SqlValidatorTest`. you can search for `.checkFails(` from the test file to get some usage examples.
[1] https://dev.mysql.com/doc/refman/8.0/en/keywords.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services