You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-dev@incubator.apache.org by Matthias Wessendorf <ma...@apache.org> on 2007/04/26 15:52:35 UTC
[client side conversion] NumberConverter
Hi,
there is a minimalistic version of the client side converter for the
NumberConverter, but this client side converter is causing some
issues. There might be some *tool* that help us (me) to get a better
version. However, does anyone mind to apply the patch for
https://issues.apache.org/jira/browse/ADFFACES-468
in the mean time ?
(it's only a subtask of a bug, saying, we need a client side number converter)
-M
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: [client side conversion] NumberConverter
Posted by Matthias Wessendorf <ma...@apache.org>.
new patch
On 4/26/07, Matthias Wessendorf <ma...@apache.org> wrote:
> On 4/26/07, Adam Winer <aw...@gmail.com> wrote:
> > I'm confused about this patch:
> >
> > - if(this._isConvertible())
> > + if(!(numberString.indexOf(',') != -1 || numberString.indexOf(',') !=
> > -1) && this._isConvertible())
> > {
> > return _decimalParse(numberString,
> > this._messages,
> >
> > Why is numberString.indexOf(',') != -1 being checked twice?
>
> typo ...
>
> '.' and ','
> > And, if you're trying to use the numeric separator, shouldn't
> > this be localized, not a hardcoded character?
>
> yes, I'll check that as well
>
> >
> > -- Adam
> >
> >
> > On 4/26/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > Hi,
> > >
> > > there is a minimalistic version of the client side converter for the
> > > NumberConverter, but this client side converter is causing some
> > > issues. There might be some *tool* that help us (me) to get a better
> > > version. However, does anyone mind to apply the patch for
> > >
> > > https://issues.apache.org/jira/browse/ADFFACES-468
> > >
> > > in the mean time ?
> > > (it's only a subtask of a bug, saying, we need a client side number converter)
> > >
> > > -M
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: [client side conversion] NumberConverter
Posted by Matthias Wessendorf <ma...@apache.org>.
On 4/26/07, Adam Winer <aw...@gmail.com> wrote:
> I'm confused about this patch:
>
> - if(this._isConvertible())
> + if(!(numberString.indexOf(',') != -1 || numberString.indexOf(',') !=
> -1) && this._isConvertible())
> {
> return _decimalParse(numberString,
> this._messages,
>
> Why is numberString.indexOf(',') != -1 being checked twice?
typo ...
'.' and ','
> And, if you're trying to use the numeric separator, shouldn't
> this be localized, not a hardcoded character?
yes, I'll check that as well
>
> -- Adam
>
>
> On 4/26/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > Hi,
> >
> > there is a minimalistic version of the client side converter for the
> > NumberConverter, but this client side converter is causing some
> > issues. There might be some *tool* that help us (me) to get a better
> > version. However, does anyone mind to apply the patch for
> >
> > https://issues.apache.org/jira/browse/ADFFACES-468
> >
> > in the mean time ?
> > (it's only a subtask of a bug, saying, we need a client side number converter)
> >
> > -M
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: [client side conversion] NumberConverter
Posted by Adam Winer <aw...@gmail.com>.
I'm confused about this patch:
- if(this._isConvertible())
+ if(!(numberString.indexOf(',') != -1 || numberString.indexOf(',') !=
-1) && this._isConvertible())
{
return _decimalParse(numberString,
this._messages,
Why is numberString.indexOf(',') != -1 being checked twice?
And, if you're trying to use the numeric separator, shouldn't
this be localized, not a hardcoded character?
-- Adam
On 4/26/07, Matthias Wessendorf <ma...@apache.org> wrote:
> Hi,
>
> there is a minimalistic version of the client side converter for the
> NumberConverter, but this client side converter is causing some
> issues. There might be some *tool* that help us (me) to get a better
> version. However, does anyone mind to apply the patch for
>
> https://issues.apache.org/jira/browse/ADFFACES-468
>
> in the mean time ?
> (it's only a subtask of a bug, saying, we need a client side number converter)
>
> -M
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>