You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2010/12/24 03:31:45 UTC
[jira] Created: (SOLR-2297) make XMLWriter extend
TextResponseWriter, deprecate FieldType.write(XMLWriter,...)
make XMLWriter extend TextResponseWriter, deprecate FieldType.write(XMLWriter,...)
----------------------------------------------------------------------------------
Key: SOLR-2297
URL: https://issues.apache.org/jira/browse/SOLR-2297
Project: Solr
Issue Type: Improvement
Reporter: Yonik Seeley
We should merge XMLWriter into the TextResponseWriter framework.
This will make it easier to maintain, and pave the way for easier pseudo-field implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2297) make XMLWriter extend
TextResponseWriter, deprecate FieldType.write(XMLWriter,...)
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974822#action_12974822 ]
Yonik Seeley commented on SOLR-2297:
------------------------------------
One issue in sharing code between the JSON and XML writers (via a common base class) is
all the methods added to JSONResponseWriter to support the PHPS format.
Not sure how important this format is for people... and some have suggested deprecating/removing it.
> make XMLWriter extend TextResponseWriter, deprecate FieldType.write(XMLWriter,...)
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2297
> URL: https://issues.apache.org/jira/browse/SOLR-2297
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
>
> We should merge XMLWriter into the TextResponseWriter framework.
> This will make it easier to maintain, and pave the way for easier pseudo-field implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2297) make XMLWriter extend
TextResponseWriter, deprecate FieldType.write(XMLWriter,...)
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-2297:
-------------------------------
Attachment: SOLR-2297.patch
OK, here's a patch that finally gets rid of the separate FieldType.write method for XML (I had meant to do this back in '05 !) and gets rid of at least some of the code duplication.
> make XMLWriter extend TextResponseWriter, deprecate FieldType.write(XMLWriter,...)
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2297
> URL: https://issues.apache.org/jira/browse/SOLR-2297
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Attachments: SOLR-2297.patch
>
>
> We should merge XMLWriter into the TextResponseWriter framework.
> This will make it easier to maintain, and pave the way for easier pseudo-field implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (SOLR-2297) make XMLWriter extend
TextResponseWriter, deprecate FieldType.write(XMLWriter,...)
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved SOLR-2297.
--------------------------------
Resolution: Fixed
Fix Version/s: 4.0
> make XMLWriter extend TextResponseWriter, deprecate FieldType.write(XMLWriter,...)
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2297
> URL: https://issues.apache.org/jira/browse/SOLR-2297
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 4.0
>
> Attachments: SOLR-2297.patch
>
>
> We should merge XMLWriter into the TextResponseWriter framework.
> This will make it easier to maintain, and pave the way for easier pseudo-field implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org