You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Namit Maheshwari <nm...@hortonworks.com> on 2015/05/08 02:55:53 UTC
Review Request 33965: Feed Setup tests for testing header and default
scenario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33965/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1201
https://issues.apache.org/jira/browse/FALCON-1201
Repository: falcon-git
Description
-------
Feed Setup tests for testing header and default scenario
Diffs
-----
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java eaaeba25307bf2f494d76cd5de080aadcbd6ce54
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java PRE-CREATION
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewFeedPage.java 4863da3e146d23eef0f749766e5040d0a1cbc154
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java b9d766f722377cf36eb08a938f8f38b143021f28
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/33965/diff/
Testing
-------
Tested, that the pages are filled fine and test pass.
Thanks,
Namit Maheshwari
Re: Review Request 33965: Feed Setup tests for testing header and
default scenario
Posted by Namit Maheshwari <nm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33965/
-----------------------------------------------------------
(Updated May 12, 2015, 6:47 p.m.)
Review request for Falcon.
Bugs: FALCON-1201
https://issues.apache.org/jira/browse/FALCON-1201
Repository: falcon-git
Description
-------
Test 1. testHeader
Test 2. testWizardDefaultScenario - Run full feed creation scenario.
Diffs (updated)
-----
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java eaaeba25307bf2f494d76cd5de080aadcbd6ce54
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java PRE-CREATION
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewFeedPage.java 4863da3e146d23eef0f749766e5040d0a1cbc154
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java b9d766f722377cf36eb08a938f8f38b143021f28
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/33965/diff/
Testing
-------
Tested, that the pages are filled fine and test pass.
Thanks,
Namit Maheshwari
Re: Review Request 33965: Feed Setup tests for testing header and
default scenario
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33965/#review83401
-----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java
<https://reviews.apache.org/r/33965/#comment134389>
lets use camel-case instead of "_".
Also (int i=0; i < tags.length ;i++)
-> (int i = 0; i < tags.length; i++)
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java
<https://reviews.apache.org/r/33965/#comment134387>
It seems that logger class should be FeedSetupTest
- Paul Isaychuk
On May 8, 2015, 12:58 a.m., Namit Maheshwari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33965/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 12:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1201
> https://issues.apache.org/jira/browse/FALCON-1201
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test 1. testHeader
> Test 2. testWizardDefaultScenario - Run full feed creation scenario.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java eaaeba25307bf2f494d76cd5de080aadcbd6ce54
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java PRE-CREATION
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewFeedPage.java 4863da3e146d23eef0f749766e5040d0a1cbc154
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java b9d766f722377cf36eb08a938f8f38b143021f28
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33965/diff/
>
>
> Testing
> -------
>
> Tested, that the pages are filled fine and test pass.
>
>
> Thanks,
>
> Namit Maheshwari
>
>
Re: Review Request 33965: Feed Setup tests for testing header and
default scenario
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33965/#review83116
-----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java
<https://reviews.apache.org/r/33965/#comment133987>
Inconsistent indentation. Pleave run:
mvn -Phadoop2 clean verify
For intellij you can use this profile, which will do a good part of the work for you:
https://docs.google.com/a/hortonworks.com/file/d/0BzSi0sEwnHOaVWZERllsSEpReUk/edit
Looks good to me. Since, I was guiding Namit with the process, it would be better if someone else also reviews it.
- Raghav Gautam
On May 7, 2015, 5:58 p.m., Namit Maheshwari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33965/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 5:58 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1201
> https://issues.apache.org/jira/browse/FALCON-1201
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test 1. testHeader
> Test 2. testWizardDefaultScenario - Run full feed creation scenario.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java eaaeba25307bf2f494d76cd5de080aadcbd6ce54
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java PRE-CREATION
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewFeedPage.java 4863da3e146d23eef0f749766e5040d0a1cbc154
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java b9d766f722377cf36eb08a938f8f38b143021f28
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33965/diff/
>
>
> Testing
> -------
>
> Tested, that the pages are filled fine and test pass.
>
>
> Thanks,
>
> Namit Maheshwari
>
>
Re: Review Request 33965: Feed Setup tests for testing header and
default scenario
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33965/#review83407
-----------------------------------------------------------
Ship it!
Ship It!
- Paul Isaychuk
On May 8, 2015, 12:58 a.m., Namit Maheshwari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33965/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 12:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1201
> https://issues.apache.org/jira/browse/FALCON-1201
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test 1. testHeader
> Test 2. testWizardDefaultScenario - Run full feed creation scenario.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java eaaeba25307bf2f494d76cd5de080aadcbd6ce54
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java PRE-CREATION
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewFeedPage.java 4863da3e146d23eef0f749766e5040d0a1cbc154
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java b9d766f722377cf36eb08a938f8f38b143021f28
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33965/diff/
>
>
> Testing
> -------
>
> Tested, that the pages are filled fine and test pass.
>
>
> Thanks,
>
> Namit Maheshwari
>
>
Re: Review Request 33965: Feed Setup tests for testing header and
default scenario
Posted by Namit Maheshwari <nm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33965/
-----------------------------------------------------------
(Updated May 8, 2015, 12:58 a.m.)
Review request for Falcon.
Bugs: FALCON-1201
https://issues.apache.org/jira/browse/FALCON-1201
Repository: falcon-git
Description (updated)
-------
Test 1. testHeader
Test 2. testWizardDefaultScenario - Run full feed creation scenario.
Diffs
-----
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java eaaeba25307bf2f494d76cd5de080aadcbd6ce54
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java PRE-CREATION
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewFeedPage.java 4863da3e146d23eef0f749766e5040d0a1cbc154
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java b9d766f722377cf36eb08a938f8f38b143021f28
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/33965/diff/
Testing
-------
Tested, that the pages are filled fine and test pass.
Thanks,
Namit Maheshwari