You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "NobiGo (via GitHub)" <gi...@apache.org> on 2023/07/05 01:05:44 UTC

[GitHub] [calcite] NobiGo commented on a diff in pull request #3291: [CALCITE-5816] Only return left-hand table columns when validate LEFT SEMI JOIN query

NobiGo commented on code in PR #3291:
URL: https://github.com/apache/calcite/pull/3291#discussion_r1252431597


##########
babel/src/test/java/org/apache/calcite/test/BabelTest.java:
##########
@@ -130,6 +131,17 @@ private void checkInfixCast(Statement statement, String typeName, int sqlType)
   /** Tests that you can run tests via {@link Fixtures}. */
   @Test void testFixtures() {
     final SqlValidatorFixture v = Fixtures.forValidator();
+
+    v.withParserConfig(c -> c.withParserFactory(SqlBabelParserImpl.FACTORY))

Review Comment:
   How about we extract the test to testLeftSemiJoin?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org