You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2018/02/06 19:59:18 UTC
[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9226
Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
......................................................................
Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
This reverts commit 9b68645f9eb9e08899fda860e0946cc05f205479.
Change-Id: Ia06f061a4ecedd1df0d359fe06fe84618b5e07fb
---
M be/src/runtime/tmp-file-mgr.cc
M be/src/util/cpu-info.cc
M be/src/util/cpu-info.h
M be/src/util/openssl-util-test.cc
M be/src/util/openssl-util.cc
M be/src/util/openssl-util.h
6 files changed, 73 insertions(+), 227 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/9226/1
--
To view, visit http://gerrit.cloudera.org:8080/9226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia06f061a4ecedd1df0d359fe06fe84618b5e07fb
Gerrit-Change-Number: 9226
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9226 )
Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia06f061a4ecedd1df0d359fe06fe84618b5e07fb
Gerrit-Change-Number: 9226
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Feb 2018 23:40:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9226 )
Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1890/
--
To view, visit http://gerrit.cloudera.org:8080/9226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia06f061a4ecedd1df0d359fe06fe84618b5e07fb
Gerrit-Change-Number: 9226
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Feb 2018 20:02:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9226 )
Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia06f061a4ecedd1df0d359fe06fe84618b5e07fb
Gerrit-Change-Number: 9226
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Feb 2018 20:01:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9226 )
Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
......................................................................
Patch Set 1:
I believe this is breaking all builds because the BE fails to compile. See:
https://issues.apache.org/jira/browse/IMPALA-6485
--
To view, visit http://gerrit.cloudera.org:8080/9226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia06f061a4ecedd1df0d359fe06fe84618b5e07fb
Gerrit-Change-Number: 9226
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Feb 2018 20:00:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9226 )
Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
......................................................................
Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"
This reverts commit 9b68645f9eb9e08899fda860e0946cc05f205479.
Change-Id: Ia06f061a4ecedd1df0d359fe06fe84618b5e07fb
Reviewed-on: http://gerrit.cloudera.org:8080/9226
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/tmp-file-mgr.cc
M be/src/util/cpu-info.cc
M be/src/util/cpu-info.h
M be/src/util/openssl-util-test.cc
M be/src/util/openssl-util.cc
M be/src/util/openssl-util.h
6 files changed, 73 insertions(+), 227 deletions(-)
Approvals:
Sailesh Mukil: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia06f061a4ecedd1df0d359fe06fe84618b5e07fb
Gerrit-Change-Number: 9226
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>