You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/20 09:39:51 UTC

[GitHub] [spark] xuanyuanking commented on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

xuanyuanking commented on pull request #31989:
URL: https://github.com/apache/spark/pull/31989#issuecomment-823135370


   @viirya Sorry for the late. Just back from the work on open-sourcing RocksDBStateStore. Since the design has been published. I can back to this now.
   I'm +1 for the `StreamingSessionWindowStateManager` abstraction. Only have some concern about the StreamingSessionWindowStateManagerImplV1. It would be great if we can have a better state store API to reduce the complexity of the implementation. I'll start working on it in these two weeks (in parallel with open-sourcing the RocksDB state store).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org