[GitHub] [hadoop] liuml07 commented on a change in pull request #1752: HADOOP-16732. S3Guard to support encrypted DynamoDB table

[GitBox <gi...@apache.org>]

liuml07 commented on a change in pull request #1752: HADOOP-16732. S3Guard to support encrypted DynamoDB table
URL: https://github.com/apache/hadoop/pull/1752#discussion_r368195284
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStoreTableManager.java
 ##########
 @@ -322,6 +326,24 @@ private void createTable(ProvisionedThroughput capacity) throws IOException {
     putVersionMarkerItemToTable();
   }
 
+  /**
+   * Get DynamoDB table server side encryption (SSE) settings from configuration.
+   */
+  private SSESpecification getSseSpecFromConfig() {
+    final SSESpecification sseSpecification = new SSESpecification();
+    sseSpecification.setEnabled(conf.getBoolean(S3GUARD_DDB_TABLE_SSE_ENABLED, false));
+    String cmk = conf.get(S3GUARD_DDB_TABLE_SSE_CMK);
 
 Review comment:
   The decision (between Steve and me) is: in S3Guard command tool we don't support changing encryption algorithm or CMK. Instead, users should go to AWS console (or AWS CLI) for that. S3Guard command tool provisions DynamoDB table if needed, while it is not going to be the best place for DynamoDB table management like billing mode, encryption, tagging etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org