You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/29 13:29:38 UTC
[GitHub] [spark] sarutak opened a new pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
sarutak opened a new pull request #34142:
URL: https://github.com/apache/spark/pull/34142
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR aims to support reading and writing ANSI intervals from/to CSV datasources.
Aith this change, a interval data is written as a literal form like `INTERVAL '1-2' YEAR TO MONTH`.
For the reading part, we need to specify the schema explicitly like:
```
val readDF = spark.read.schema("col INTERVAL YEAR TO MONTH").csv(...)
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For better usability. There should be no reason to prohibit from reading/writing ANSI intervals from/to CSV datasources.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New test. It covers both V1 and V2 sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930283331
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930178585
**[Test build #143716 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143716/testReport)** for PR 34142 at commit [`ceda0fc`](https://github.com/apache/spark/commit/ceda0fc72255f752ba064b10cd7bfee888fbfc63).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930430814
+1, LGTM. Merging to master.
Thank you, @sarutak .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34142:
URL: https://github.com/apache/spark/pull/34142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930429217
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143716/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930429217
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143716/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930178585
**[Test build #143716 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143716/testReport)** for PR 34142 at commit [`ceda0fc`](https://github.com/apache/spark/commit/ceda0fc72255f752ba064b10cd7bfee888fbfc63).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930430814
+1, LGTM. Merging to master.
Thank you, @sarutak .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930283294
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930283331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930227222
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34142:
URL: https://github.com/apache/spark/pull/34142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930178585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930283331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930283331
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930418346
**[Test build #143716 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143716/testReport)** for PR 34142 at commit [`ceda0fc`](https://github.com/apache/spark/commit/ceda0fc72255f752ba064b10cd7bfee888fbfc63).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34142: [SPARK-36831][SQL] Support reading and writing ANSI intervals from/to CSV datasources.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34142:
URL: https://github.com/apache/spark/pull/34142#issuecomment-930178585
**[Test build #143716 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143716/testReport)** for PR 34142 at commit [`ceda0fc`](https://github.com/apache/spark/commit/ceda0fc72255f752ba064b10cd7bfee888fbfc63).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org