[jira] [Commented] (OWB-880) OpenWebBeans Arquillian Container rely on bad Archive instance assumptions

["Romain Manni-Bucau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OWB-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710037#comment-13710037 ] 

Romain Manni-Bucau commented on OWB-880:
----------------------------------------

commited the fix on trunk. thanks!
                
> OpenWebBeans Arquillian Container rely on bad Archive instance assumptions
> --------------------------------------------------------------------------
>
>                 Key: OWB-880
>                 URL: https://issues.apache.org/jira/browse/OWB-880
>             Project: OpenWebBeans
>          Issue Type: Improvement
>    Affects Versions: 1.1.8
>            Reporter: Aslak Knutsen
>
> When scanning the incoming deployment it's a bad idea to rely on the instanceOf archive types. It hinders users from creating custom Archvie Wrapper types.
> e.g. 
> https://github.com/apache/openwebbeans/blob/owb_1.1.x/webbeans-arquillian/owb-arquillian-standalone/src/main/java/org/apache/webbeans/arquillian/standalone/OwbArquillianScannerService.java#L92
> https://github.com/apache/openwebbeans/blob/owb_1.1.x/webbeans-arquillian/owb-arquillian-standalone/src/main/java/org/apache/webbeans/arquillian/standalone/OwbArquillianScannerService.java#L160
> To check for Archive type use: 
> {code}
> archive.getName().endsWith(".jar")
> {code}
> To 'cast' to a JavaArchive use:
> {code}
> archive.as(JavaArchive.class)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira